From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Stanislav Fomichev <stfomichev@yandex-team.ru>,
Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ramkumar Ramachandra <artagnon@gmail.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 03/10] perf timechart: Print pid along the name
Date: Tue, 17 Dec 2013 17:52:04 -0300 [thread overview]
Message-ID: <1387313531-14629-4-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1387313531-14629-1-git-send-email-acme@infradead.org>
From: Stanislav Fomichev <stfomichev@yandex-team.ru>
Add PID to the figures of CPU usage timechart.
Signed-off-by: Stanislav Fomichev <stfomichev@yandex-team.ru>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ramkumar Ramachandra <artagnon@gmail.com>
Link: http://lkml.kernel.org/r/1385995056-20158-3-git-send-email-stfomichev@yandex-team.ru
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-timechart.c | 1 +
tools/perf/util/svghelper.c | 4 ++--
tools/perf/util/svghelper.h | 2 +-
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c
index d955095b6d63..99fe363f1de8 100644
--- a/tools/perf/builtin-timechart.c
+++ b/tools/perf/builtin-timechart.c
@@ -841,6 +841,7 @@ static void draw_cpu_usage(struct timechart *tchart)
svg_process(sample->cpu,
sample->start_time,
sample->end_time,
+ p->pid,
"sample",
c->comm,
sample->backtrace);
diff --git a/tools/perf/util/svghelper.c b/tools/perf/util/svghelper.c
index 740f0328fc13..927851d05d03 100644
--- a/tools/perf/util/svghelper.c
+++ b/tools/perf/util/svghelper.c
@@ -285,7 +285,7 @@ void svg_cpu_box(int cpu, u64 __max_freq, u64 __turbo_freq)
fprintf(svgfile, "</g>\n");
}
-void svg_process(int cpu, u64 start, u64 end, const char *type, const char *name, const char *backtrace)
+void svg_process(int cpu, u64 start, u64 end, int pid, const char *type, const char *name, const char *backtrace)
{
double width;
@@ -294,7 +294,7 @@ void svg_process(int cpu, u64 start, u64 end, const char *type, const char *name
fprintf(svgfile, "<g transform=\"translate(%4.8f,%4.8f)\">\n", time2pixels(start), cpu2y(cpu));
- fprintf(svgfile, "<title>%s %s</title>\n", name, time_to_string(end - start));
+ fprintf(svgfile, "<title>%d %s running %s</title>\n", pid, name, time_to_string(end - start));
if (backtrace)
fprintf(svgfile, "<desc>Switched because:\n%s</desc>\n", backtrace);
fprintf(svgfile, "<rect x=\"0\" width=\"%4.8f\" y=\"0\" height=\"%4.1f\" class=\"%s\"/>\n",
diff --git a/tools/perf/util/svghelper.h b/tools/perf/util/svghelper.h
index 7db6ae98bf2c..8b77ca631686 100644
--- a/tools/perf/util/svghelper.h
+++ b/tools/perf/util/svghelper.h
@@ -11,7 +11,7 @@ extern void svg_waiting(int Yslot, int cpu, u64 start, u64 end, const char *back
extern void svg_cpu_box(int cpu, u64 max_frequency, u64 turbo_frequency);
-extern void svg_process(int cpu, u64 start, u64 end, const char *type, const char *name, const char *backtrace);
+extern void svg_process(int cpu, u64 start, u64 end, int pid, const char *type, const char *name, const char *backtrace);
extern void svg_cstate(int cpu, u64 start, u64 end, int type);
extern void svg_pstate(int cpu, u64 start, u64 end, u64 freq);
--
1.8.1.4
next prev parent reply other threads:[~2013-12-17 20:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 20:52 [GIT PULL 00/10] perf/core improvements and refactorings Arnaldo Carvalho de Melo
2013-12-17 20:52 ` [PATCH 01/10] tools/: Convert to new topic libraries Arnaldo Carvalho de Melo
2013-12-17 20:52 ` [PATCH 02/10] perf timechart: Add backtrace support to CPU info Arnaldo Carvalho de Melo
2013-12-17 20:52 ` Arnaldo Carvalho de Melo [this message]
2013-12-17 20:52 ` [PATCH 04/10] perf timechart: Get number of CPUs from perf header Arnaldo Carvalho de Melo
2013-12-17 20:52 ` [PATCH 05/10] perf timechart: Add support for topology Arnaldo Carvalho de Melo
2013-12-17 20:52 ` [PATCH 06/10] perf symbols: Remove needless static binary_type array Arnaldo Carvalho de Melo
2013-12-17 20:52 ` [PATCH 07/10] perf symbols: Clarify method to get DSO binary_type filename Arnaldo Carvalho de Melo
2013-12-17 20:52 ` [PATCH 08/10] perf timechart: Add --highlight option Arnaldo Carvalho de Melo
2013-12-17 20:52 ` [PATCH 09/10] perf symbols: Use consistent name for the DSO binary type member Arnaldo Carvalho de Melo
2013-12-17 20:52 ` [PATCH 10/10] tools lib traceevent: Get rid of die() in some string conversion functions Arnaldo Carvalho de Melo
2013-12-18 10:13 ` [GIT PULL 00/10] perf/core improvements and refactorings Ingo Molnar
2013-12-18 12:11 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387313531-14629-4-git-send-email-acme@infradead.org \
--to=acme@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=artagnon@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=stfomichev@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®