mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Jiri Olsa <jolsa@redhat.com>, Mike Galbraith <efault@gmx.de>,
	Namhyung Kim <namhyung@kernel.org>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Stephane Eranian <eranian@google.com>
Subject: [PATCH 06/10] perf symbols: Remove needless static binary_type array
Date: Tue, 17 Dec 2013 17:52:07 -0300	[thread overview]
Message-ID: <1387313531-14629-7-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1387313531-14629-1-git-send-email-acme@infradead.org>

From: Arnaldo Carvalho de Melo <acme@redhat.com>

There are no references to that array anywhere, it is only used to try
a series of "binary" types in turn, always setting dso->data_type till
one can be used.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-4mw7xrbs12tln6v2uthg7sqc@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/dso.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c
index 436922f1f9d9..e7f4449088e4 100644
--- a/tools/perf/util/dso.c
+++ b/tools/perf/util/dso.c
@@ -161,7 +161,7 @@ static int open_dso(struct dso *dso, struct machine *machine)
 
 int dso__data_fd(struct dso *dso, struct machine *machine)
 {
-	static enum dso_binary_type binary_type_data[] = {
+	enum dso_binary_type binary_type_data[] = {
 		DSO_BINARY_TYPE__BUILD_ID_CACHE,
 		DSO_BINARY_TYPE__SYSTEM_PATH_DSO,
 		DSO_BINARY_TYPE__NOT_FOUND,
-- 
1.8.1.4


  parent reply	other threads:[~2013-12-17 20:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17 20:52 [GIT PULL 00/10] perf/core improvements and refactorings Arnaldo Carvalho de Melo
2013-12-17 20:52 ` [PATCH 01/10] tools/: Convert to new topic libraries Arnaldo Carvalho de Melo
2013-12-17 20:52 ` [PATCH 02/10] perf timechart: Add backtrace support to CPU info Arnaldo Carvalho de Melo
2013-12-17 20:52 ` [PATCH 03/10] perf timechart: Print pid along the name Arnaldo Carvalho de Melo
2013-12-17 20:52 ` [PATCH 04/10] perf timechart: Get number of CPUs from perf header Arnaldo Carvalho de Melo
2013-12-17 20:52 ` [PATCH 05/10] perf timechart: Add support for topology Arnaldo Carvalho de Melo
2013-12-17 20:52 ` Arnaldo Carvalho de Melo [this message]
2013-12-17 20:52 ` [PATCH 07/10] perf symbols: Clarify method to get DSO binary_type filename Arnaldo Carvalho de Melo
2013-12-17 20:52 ` [PATCH 08/10] perf timechart: Add --highlight option Arnaldo Carvalho de Melo
2013-12-17 20:52 ` [PATCH 09/10] perf symbols: Use consistent name for the DSO binary type member Arnaldo Carvalho de Melo
2013-12-17 20:52 ` [PATCH 10/10] tools lib traceevent: Get rid of die() in some string conversion functions Arnaldo Carvalho de Melo
2013-12-18 10:13 ` [GIT PULL 00/10] perf/core improvements and refactorings Ingo Molnar
2013-12-18 12:11   ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387313531-14629-7-git-send-email-acme@infradead.org \
    --to=acme@infradead.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=dsahern@gmail.com \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®