* [PATCH] ASoC: simple-card: Cleanup __asoc_simple_card_dai_init() ret check
@ 2013-12-23 5:24 Xiubo Li
2013-12-31 12:49 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Xiubo Li @ 2013-12-23 5:24 UTC (permalink / raw)
To: broonie, lgirdwood
Cc: rob, kuninori.morimoto.gx, fabio.estevam, alsa-devel, linux-doc,
linux-kernel
The ret parameter is always equal to zero till here.
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
---
sound/soc/generic/simple-card.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c
index 643c9ed..6ce9745 100644
--- a/sound/soc/generic/simple-card.c
+++ b/sound/soc/generic/simple-card.c
@@ -25,7 +25,7 @@ static int __asoc_simple_card_dai_init(struct snd_soc_dai *dai,
daifmt |= set->fmt;
- if (!ret && daifmt)
+ if (daifmt)
ret = snd_soc_dai_set_fmt(dai, daifmt);
if (ret == -ENOTSUPP) {
--
1.8.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: simple-card: Cleanup __asoc_simple_card_dai_init() ret check
2013-12-23 5:24 [PATCH] ASoC: simple-card: Cleanup __asoc_simple_card_dai_init() ret check Xiubo Li
@ 2013-12-31 12:49 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-12-31 12:49 UTC (permalink / raw)
To: Xiubo Li
Cc: lgirdwood, rob, kuninori.morimoto.gx, fabio.estevam, alsa-devel,
linux-doc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
On Mon, Dec 23, 2013 at 01:24:59PM +0800, Xiubo Li wrote:
> The ret parameter is always equal to zero till here.
Applied, thanks. This is on the edge of what's a good cleanup - it's
a taste thing if it's better to have every call be the same so the code
looks more regular or if it's better to have the redundant test removed.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-31 12:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-23 5:24 [PATCH] ASoC: simple-card: Cleanup __asoc_simple_card_dai_init() ret check Xiubo Li
2013-12-31 12:49 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®