mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [patch] sched: Fix up /proc/sched_debug to print only runnable tasks again
@ 2013-12-23  6:39 Mike Galbraith
  0 siblings, 0 replies; only message in thread
From: Mike Galbraith @ 2013-12-23  6:39 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: LKML

Hi Ingo,

This hunk of b32e86b430 looks like a booboo.


Commit b32e86b430 dropped p->on_rq check, leading to printing tasks which
used to live on runqueues, which is very noisy (and annoying as heck).

Signed-off-by: Mike Galbraith <bitbucket@online.de>
---
 kernel/sched/debug.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/kernel/sched/debug.c
+++ b/kernel/sched/debug.c
@@ -163,7 +163,7 @@ static void print_rq(struct seq_file *m,
 	read_lock_irqsave(&tasklist_lock, flags);
 
 	do_each_thread(g, p) {
-		if (task_cpu(p) != rq_cpu)
+		if (!p->on_rq || task_cpu(p) != rq_cpu)
 			continue;
 
 		print_task(m, rq, p);



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2013-12-23  6:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-23  6:39 [patch] sched: Fix up /proc/sched_debug to print only runnable tasks again Mike Galbraith

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®