From: Jan Kara <jack@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: pmladek@suse.cz, Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>, Jan Kara <jack@suse.cz>
Subject: [PATCH 5/9] smp: Provide __smp_call_function_any()
Date: Mon, 23 Dec 2013 21:39:26 +0100 [thread overview]
Message-ID: <1387831171-5264-6-git-send-email-jack@suse.cz> (raw)
In-Reply-To: <1387831171-5264-1-git-send-email-jack@suse.cz>
Provide function to call given function on any cpu from a given cpu mask
while providing own csd structure.
Signed-off-by: Jan Kara <jack@suse.cz>
---
include/linux/smp.h | 9 +++++++
kernel/smp.c | 67 +++++++++++++++++++++++++++++++++++++++--------------
2 files changed, 58 insertions(+), 18 deletions(-)
diff --git a/include/linux/smp.h b/include/linux/smp.h
index 1e8c72100eda..37aa794a93ce 100644
--- a/include/linux/smp.h
+++ b/include/linux/smp.h
@@ -100,6 +100,8 @@ void smp_call_function_many(const struct cpumask *mask,
int smp_call_function_any(const struct cpumask *mask,
smp_call_func_t func, void *info, int wait);
+int __smp_call_function_any(const struct cpumask *mask,
+ struct call_single_data *csd, int wait);
void kick_all_cpus_sync(void);
@@ -149,6 +151,13 @@ smp_call_function_any(const struct cpumask *mask, smp_call_func_t func,
return smp_call_function_single(0, func, info, wait);
}
+static inline int
+__smp_call_function_any(const struct cpumask *mask,
+ struct call_single_data *csd, int wait)
+{
+ return __smp_call_function_single(0, csd, wait);
+}
+
static inline void kick_all_cpus_sync(void) { }
#endif /* !SMP */
diff --git a/kernel/smp.c b/kernel/smp.c
index 2efcfa1d11ee..4c44554ff5b6 100644
--- a/kernel/smp.c
+++ b/kernel/smp.c
@@ -238,6 +238,27 @@ int smp_call_function_single(int cpu, smp_call_func_t func, void *info,
}
EXPORT_SYMBOL(smp_call_function_single);
+static unsigned int pick_any_cpu(const struct cpumask *mask)
+{
+ unsigned int cpu = smp_processor_id();
+ const struct cpumask *nodemask;
+
+ /* Try for same CPU (cheapest) */
+ if (cpumask_test_cpu(cpu, mask))
+ return cpu;
+
+ /* Try for same node. */
+ nodemask = cpumask_of_node(cpu_to_node(cpu));
+ for (cpu = cpumask_first_and(nodemask, mask); cpu < nr_cpu_ids;
+ cpu = cpumask_next_and(cpu, nodemask, mask)) {
+ if (cpu_online(cpu))
+ return cpu;
+ }
+
+ /* Any online will do */
+ return cpumask_any_and(mask, cpu_online_mask);
+}
+
/*
* smp_call_function_any - Run a function on any of the given cpus
* @mask: The mask of cpus it can run on.
@@ -256,27 +277,13 @@ int smp_call_function_any(const struct cpumask *mask,
smp_call_func_t func, void *info, int wait)
{
unsigned int cpu;
- const struct cpumask *nodemask;
int ret;
- /* Try for same CPU (cheapest) */
- cpu = get_cpu();
- if (cpumask_test_cpu(cpu, mask))
- goto call;
-
- /* Try for same node. */
- nodemask = cpumask_of_node(cpu_to_node(cpu));
- for (cpu = cpumask_first_and(nodemask, mask); cpu < nr_cpu_ids;
- cpu = cpumask_next_and(cpu, nodemask, mask)) {
- if (cpu_online(cpu))
- goto call;
- }
-
- /* Any online will do: smp_call_function_single handles nr_cpu_ids. */
- cpu = cpumask_any_and(mask, cpu_online_mask);
-call:
+ preempt_disable();
+ cpu = pick_any_cpu(mask);
+ /* smp_call_function_single handles nr_cpu_ids. */
ret = smp_call_function_single(cpu, func, info, wait);
- put_cpu();
+ preempt_enable();
return ret;
}
EXPORT_SYMBOL_GPL(smp_call_function_any);
@@ -322,6 +329,30 @@ int __smp_call_function_single(int cpu, struct call_single_data *csd, int wait)
}
EXPORT_SYMBOL_GPL(__smp_call_function_single);
+/*
+ * __smp_call_function_any - Run a function on any of the given cpus
+ * @mask: The mask of cpus it can run on.
+ * @csd: Pre-allocated and setup data structure
+ * @wait: If true, wait until function has completed.
+ *
+ * Like smp_call_function_any() but allow caller to pass in a pre-allocated
+ * data structure.
+ */
+int __smp_call_function_any(const struct cpumask *mask,
+ struct call_single_data *csd, int wait)
+{
+ unsigned int cpu;
+ int ret;
+
+ preempt_disable();
+ cpu = pick_any_cpu(mask);
+ /* smp_call_function_single handles nr_cpu_ids. */
+ ret = __smp_call_function_single(cpu, csd, wait);
+ preempt_enable();
+ return ret;
+}
+EXPORT_SYMBOL_GPL(__smp_call_function_any);
+
/**
* smp_call_function_many(): Run a function on a set of other CPUs.
* @mask: The set of cpus to run on (only runs on online subset).
--
1.8.1.4
next prev parent reply other threads:[~2013-12-23 20:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 20:39 [PATCH 0/9] printk: Cleanups and softlockup avoidance Jan Kara
2013-12-23 20:39 ` [PATCH 1/9] block: Stop abusing csd.list for fifo_time Jan Kara
2014-02-01 16:48 ` Frederic Weisbecker
2014-02-03 14:48 ` Jan Kara
2014-02-03 17:02 ` Frederic Weisbecker
2013-12-23 20:39 ` [PATCH 2/9] block: Stop abusing rq->csd.list in blk-softirq Jan Kara
2014-01-30 12:39 ` Frederic Weisbecker
2014-01-30 15:45 ` Jan Kara
2014-01-30 17:01 ` Frederic Weisbecker
2014-01-30 22:12 ` Jan Kara
2014-01-31 15:08 ` Frederic Weisbecker
2013-12-23 20:39 ` [PATCH 3/9] kernel: use lockless list for smp_call_function_single() Jan Kara
2014-01-07 16:21 ` Frederic Weisbecker
2013-12-23 20:39 ` [PATCH 4/9] smp: Teach __smp_call_function_single() to check for offline cpus Jan Kara
2014-01-03 0:47 ` Steven Rostedt
2013-12-23 20:39 ` Jan Kara [this message]
2014-01-03 0:51 ` [PATCH 5/9] smp: Provide __smp_call_function_any() Steven Rostedt
2013-12-23 20:39 ` [PATCH 6/9] printk: Release lockbuf_lock before calling console_trylock_for_printk() Jan Kara
2014-01-03 1:53 ` Steven Rostedt
2014-01-03 7:49 ` Jan Kara
2013-12-23 20:39 ` [PATCH 7/9] printk: Enable interrupts " Jan Kara
2013-12-23 20:39 ` [PATCH 8/9] printk: Remove separate printk_sched buffers and use printk buf instead Jan Kara
2013-12-23 20:39 ` [PATCH 9/9] printk: Hand over printing to console if printing too long Jan Kara
2014-01-05 7:57 ` Andrew Morton
2014-01-06 9:46 ` Jan Kara
2014-01-13 7:28 ` Jan Kara
2014-01-15 22:23 ` Andrew Morton
2014-01-16 15:52 ` Jan Kara
2013-12-23 20:39 ` [PATCH 10/10] printk: debug: Slow down printing to 9600 bauds Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387831171-5264-6-git-send-email-jack@suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.cz \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®