From: danielfsantos@att.net
To: Mark Brown <broonie@kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Cc: Daniel Santos <daniel.santos@pobox.com>
Subject: spidev: fix hang when transfer_one_message fails
Date: Sun, 5 Jan 2014 17:39:26 -0600 [thread overview]
Message-ID: <1388965166-27334-1-git-send-email-daniel.santos@pobox.com> (raw)
This corrects a problem in spi_pump_messages() that leads to an spi
message hanging forever when a call to transfer_one_message() fails.
This failure occurs in my MCP2210 driver when the cs_change bit is set
on the last transfer in a message, an operation which the hardware does
not support.
Rationale
Since the transfer_one_message() returns an int, we must presume that it
may fail. If transfer_one_message() should never fail, it should return
void. Thus, calls to transfer_one_message() should properly manage a
failure.
Signed-off-by: Daniel Santos <daniel.santos@pobox.com>
---
drivers/spi/spi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 98f4b77..907122e 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -735,7 +735,9 @@ static void spi_pump_messages(struct kthread_work *work)
ret = master->transfer_one_message(master, master->cur_msg);
if (ret) {
dev_err(&master->dev,
- "failed to transfer one message from queue\n");
+ "failed to transfer one message from queue: %d\n", ret);
+ master->cur_msg->status = ret;
+ spi_finalize_current_message(master);
return;
}
}
--
1.8.3.2
next reply other threads:[~2014-01-05 23:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-05 23:39 danielfsantos [this message]
2014-01-05 23:52 ` *[PATCH]* " Daniel Santos
2014-01-06 12:53 ` Mark Brown
2014-01-23 16:47 ` Geert Uytterhoeven
2014-01-23 18:17 ` Mark Brown
2014-01-24 2:21 ` Daniel Santos
2014-01-24 13:01 ` Mark Brown
2014-01-27 23:16 ` Daniel Santos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388965166-27334-1-git-send-email-daniel.santos@pobox.com \
--to=danielfsantos@att.net \
--cc=broonie@kernel.org \
--cc=daniel.santos@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®