From: Mark Brown <broonie@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Daniel Santos <daniel.santos@pobox.com>,
linux-spi <linux-spi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: spidev: fix hang when transfer_one_message fails
Date: Thu, 23 Jan 2014 18:17:37 +0000 [thread overview]
Message-ID: <20140123181737.GA11727@sirena.org.uk> (raw)
In-Reply-To: <CAMuHMdU0FRi4=YejN+3TLJCwcptHVaaGFTLPyuwzO4NH9=-cUw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 337 bytes --]
On Thu, Jan 23, 2014 at 05:47:02PM +0100, Geert Uytterhoeven wrote:
> Probably your transfer_one_message() forgot to call
> spi_finalize_current_message()? Is this allowed in case of failure?
Probably not, or at least we should be consistent about requiring it or
not. Do you want to send a revert for this with a suitable changelog?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-01-23 18:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-05 23:39 danielfsantos
2014-01-05 23:52 ` *[PATCH]* " Daniel Santos
2014-01-06 12:53 ` Mark Brown
2014-01-23 16:47 ` Geert Uytterhoeven
2014-01-23 18:17 ` Mark Brown [this message]
2014-01-24 2:21 ` Daniel Santos
2014-01-24 13:01 ` Mark Brown
2014-01-27 23:16 ` Daniel Santos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140123181737.GA11727@sirena.org.uk \
--to=broonie@kernel.org \
--cc=daniel.santos@pobox.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome