mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] drm/i915: silence compiler warning
@ 2014-01-08  1:56 Ying Xue
  2014-01-08  7:35 ` Daniel Vetter
  0 siblings, 1 reply; 2+ messages in thread
From: Ying Xue @ 2014-01-08  1:56 UTC (permalink / raw)
  To: daniel.vetter; +Cc: linux-kernel, ying.xue

drivers/gpu/drm/i915/i915_debugfs.c: In function ‘display_crc_ctl_write’:
drivers/gpu/drm/i915/i915_debugfs.c:2393:2: warning: ‘val’ may be used uninitialized in this function [-Wuninitialized]
drivers/gpu/drm/i915/i915_debugfs.c:2350:6: note: ‘val’ was declared here

Signed-off-by: Ying Xue <ying.xue@windriver.com>
---
 drivers/gpu/drm/i915/i915_debugfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 6ed45a9..7963ba5 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -2347,7 +2347,7 @@ static int pipe_crc_set_source(struct drm_device *dev, enum pipe pipe,
 {
 	struct drm_i915_private *dev_priv = dev->dev_private;
 	struct intel_pipe_crc *pipe_crc = &dev_priv->pipe_crc[pipe];
-	u32 val;
+	u32 val = 0;
 	int ret;
 
 	if (pipe_crc->source == source)
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/i915: silence compiler warning
  2014-01-08  1:56 [PATCH] drm/i915: silence compiler warning Ying Xue
@ 2014-01-08  7:35 ` Daniel Vetter
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2014-01-08  7:35 UTC (permalink / raw)
  To: Ying Xue; +Cc: Linux Kernel Mailing List, intel-gfx

On Wed, Jan 8, 2014 at 2:56 AM, Ying Xue <ying.xue@windriver.com> wrote:
> drivers/gpu/drm/i915/i915_debugfs.c: In function ‘display_crc_ctl_write’:
> drivers/gpu/drm/i915/i915_debugfs.c:2393:2: warning: ‘val’ may be used uninitialized in this function [-Wuninitialized]
> drivers/gpu/drm/i915/i915_debugfs.c:2350:6: note: ‘val’ was declared here
>
> Signed-off-by: Ying Xue <ying.xue@windriver.com>

I already have such a patch in my -next queue, thanks anyway.
-Daniel


> ---
>  drivers/gpu/drm/i915/i915_debugfs.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 6ed45a9..7963ba5 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2347,7 +2347,7 @@ static int pipe_crc_set_source(struct drm_device *dev, enum pipe pipe,
>  {
>         struct drm_i915_private *dev_priv = dev->dev_private;
>         struct intel_pipe_crc *pipe_crc = &dev_priv->pipe_crc[pipe];
> -       u32 val;
> +       u32 val = 0;
>         int ret;
>
>         if (pipe_crc->source == source)
> --
> 1.7.9.5
>



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-01-08  7:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-08  1:56 [PATCH] drm/i915: silence compiler warning Ying Xue
2014-01-08  7:35 ` Daniel Vetter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®