From: Cody P Schafer <cody@linux.vnet.ibm.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <peterz@infradead.org>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: LKML <linux-kernel@vger.kernel.org>,
Cody P Schafer <cody@linux.vnet.ibm.com>
Subject: [PATCH 3/3] perf: clarify comment regarding perf_pmu_contexts
Date: Thu, 9 Jan 2014 15:51:32 -0800 [thread overview]
Message-ID: <1389311492-5059-4-git-send-email-cody@linux.vnet.ibm.com> (raw)
In-Reply-To: <1389311492-5059-1-git-send-email-cody@linux.vnet.ibm.com>
Again, note that the behavior of task_ctx_nr < 0 is an exception.
Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com>
---
kernel/events/core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index e9f60d0..159ef12 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -6276,8 +6276,9 @@ static int perf_event_idx_default(struct perf_event *event)
}
/*
- * Ensures all contexts with the same task_ctx_nr have the same
- * pmu_cpu_context too.
+ * Ensures all contexts with the same task_ctx_nr (where that task_ctx_nr
+ * is >=0) have the same pmu_cpu_context too. Contexts with with negative (<0)
+ * task_ctx_nr do not share pmu_cpu_contexts.
*/
static void *find_pmu_context(int ctxn)
{
--
1.8.5.2
next prev parent reply other threads:[~2014-01-09 23:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 23:51 [PATCH 0/3] perf: note task_ctx_nr < 0 and sw event merging behavior Cody P Schafer
2014-01-09 23:51 ` [PATCH 1/3] perf: comment on usage of perf_invalid_context Cody P Schafer
2014-01-10 9:34 ` Peter Zijlstra
2014-01-09 23:51 ` [PATCH 2/3] perf: clarify comment regarding event merging Cody P Schafer
2014-01-10 9:36 ` Peter Zijlstra
2014-01-13 21:21 ` Cody P Schafer
2014-01-09 23:51 ` Cody P Schafer [this message]
2014-01-10 9:37 ` [PATCH 3/3] perf: clarify comment regarding perf_pmu_contexts Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389311492-5059-4-git-send-email-cody@linux.vnet.ibm.com \
--to=cody@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®