From: Cody P Schafer <cody@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] perf: clarify comment regarding event merging
Date: Mon, 13 Jan 2014 13:21:44 -0800 [thread overview]
Message-ID: <52D458E8.70203@linux.vnet.ibm.com> (raw)
In-Reply-To: <20140110093635.GI31570@twins.programming.kicks-ass.net>
On 01/10/2014 01:36 AM, Peter Zijlstra wrote:
> On Thu, Jan 09, 2014 at 03:51:31PM -0800, Cody P Schafer wrote:
>> There are actually 2 things about software events that allow us to
>> merge them: they never fail to schedule _and_ they have transaction
>> handlers we can (and do, when they are added to !sw groups) ignore. Note
>> both of these in the comment on adding sw events to !sw groups.
>
> The latter is a direct consequence of the former. Since they can always
> be scheduled, they don't need any schedulability testing, and therefore
> the transaction stuff is useless.
Right. I guess what I was getting at were the 2 types of "schedulability":
1. individual event schedulability (ie: "did add() return an error?")
2. txn schedulability (ie: "did commit_txn() return an error?")
I'm in the process of adding a pmu which guarantees #1, but not #2 (it
essentially provides access to some always-running counters which can be
atomically copied in groups). As a result, I'm teasing apart some of the
special casing done for sw events.
This will probably make a bit more sense with some better terminology on
my part and some actual code. I'll update and resend later.
next prev parent reply other threads:[~2014-01-13 21:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-09 23:51 [PATCH 0/3] perf: note task_ctx_nr < 0 and sw event merging behavior Cody P Schafer
2014-01-09 23:51 ` [PATCH 1/3] perf: comment on usage of perf_invalid_context Cody P Schafer
2014-01-10 9:34 ` Peter Zijlstra
2014-01-09 23:51 ` [PATCH 2/3] perf: clarify comment regarding event merging Cody P Schafer
2014-01-10 9:36 ` Peter Zijlstra
2014-01-13 21:21 ` Cody P Schafer [this message]
2014-01-09 23:51 ` [PATCH 3/3] perf: clarify comment regarding perf_pmu_contexts Cody P Schafer
2014-01-10 9:37 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D458E8.70203@linux.vnet.ibm.com \
--to=cody@linux.vnet.ibm.com \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome