* [PATCH] spi/pxa2xx: fix compilation warning when !CONFIG_PM_SLEEP
@ 2014-01-16 12:50 Mika Westerberg
2014-01-16 14:08 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Mika Westerberg @ 2014-01-16 12:50 UTC (permalink / raw)
To: linux-spi
Cc: Eric Miao, Russell King, Haojian Zhuang, Mark Brown,
linux-kernel, Mika Westerberg
CONFIG_PM will be set if either or both CONFIG_PM_SLEEP and
CONFIG_PM_RUNTIME is set. Compiling the driver with !CONFIG_PM_SLEEP causes
following compilation warning:
drivers/spi/spi-pxa2xx.c:1270:12: warning: ‘pxa2xx_spi_suspend’ defined but not used [-Wunused-function]
Fix this by using CONFIG_PM_SLEEP instead.
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/spi/spi-pxa2xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
index cbc68848789d..c702fc536a77 100644
--- a/drivers/spi/spi-pxa2xx.c
+++ b/drivers/spi/spi-pxa2xx.c
@@ -1268,7 +1268,7 @@ static void pxa2xx_spi_shutdown(struct platform_device *pdev)
dev_err(&pdev->dev, "shutdown failed with %d\n", status);
}
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
static int pxa2xx_spi_suspend(struct device *dev)
{
struct driver_data *drv_data = dev_get_drvdata(dev);
--
1.8.5.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] spi/pxa2xx: fix compilation warning when !CONFIG_PM_SLEEP
2014-01-16 12:50 [PATCH] spi/pxa2xx: fix compilation warning when !CONFIG_PM_SLEEP Mika Westerberg
@ 2014-01-16 14:08 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-01-16 14:08 UTC (permalink / raw)
To: Mika Westerberg
Cc: linux-spi, Eric Miao, Russell King, Haojian Zhuang, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 256 bytes --]
On Thu, Jan 16, 2014 at 02:50:55PM +0200, Mika Westerberg wrote:
> CONFIG_PM will be set if either or both CONFIG_PM_SLEEP and
> CONFIG_PM_RUNTIME is set. Compiling the driver with !CONFIG_PM_SLEEP causes
> following compilation warning:
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-16 14:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-16 12:50 [PATCH] spi/pxa2xx: fix compilation warning when !CONFIG_PM_SLEEP Mika Westerberg
2014-01-16 14:08 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®