[PATCH] regulator: gpio-regulator: warn if unknown regulator type

[PATCH] regulator: gpio-regulator: warn if unknown regulator type

[Ben Dooks]

The of_get_gpio_regulator_config() will error out if there is no
"regulator_type" field in the fdt node hoewver it makes no attempt
at warning if the contents of said node is not known.

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org
---
 drivers/regulator/gpio-regulator.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c
index 234960d..e32240a 100644
--- a/drivers/regulator/gpio-regulator.c
+++ b/drivers/regulator/gpio-regulator.c
@@ -213,6 +213,8 @@ of_get_gpio_regulator_config(struct device *dev, struct device_node *np)
 		config->type = REGULATOR_VOLTAGE;
 	else if (!strncmp("current", regtype, 7))
 		config->type = REGULATOR_CURRENT;
+	else
+		dev_warn(dev, "Unknown regulator-type '%s'\n", regtype);
 
 	return config;
 }
-- 
1.8.5.2

Re: [PATCH] regulator: gpio-regulator: warn if unknown regulator type

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

On Sun, Jan 26, 2014 at 01:28:59PM +0000, Ben Dooks wrote:
> The of_get_gpio_regulator_config() will error out if there is no
> "regulator_type" field in the fdt node hoewver it makes no attempt
> at warning if the contents of said node is not known.

Please sumbit patches against current code, this won't apply since this
code has been restructured since the version you're working with and now
has an improved version of this warning.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]