From: Stefani Seibold <stefani@seibold.net>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Greg KH <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
X86 ML <x86@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Andi Kleen <ak@linux.intel.com>,
Andrea Arcangeli <aarcange@redhat.com>,
John Stultz <john.stultz@linaro.org>,
Pavel Emelyanov <xemul@parallels.com>,
Cyrill Gorcunov <gorcunov@openvz.org>,
andriy.shevchenko@linux.intel.com,
Martin.Runge@rohde-schwarz.com, Andreas.Brief@rohde-schwarz.com
Subject: Re: [PATCH 1/4] Make vsyscall_gtod_data handling x86 generic
Date: Thu, 30 Jan 2014 21:19:12 +0100 [thread overview]
Message-ID: <1391113152.1405.1.camel@wall-e.seibold.net> (raw)
In-Reply-To: <CALCETrUvKLwPccVVNpmLwxemAuE4DrmOB0C-jGTBTqcH5zPdCA@mail.gmail.com>
Am Donnerstag, den 30.01.2014, 11:51 -0800 schrieb Andy Lutomirski:
> On Thu, Jan 30, 2014 at 11:27 AM, Stefani Seibold <stefani@seibold.net> wrote:
> > Am Donnerstag, den 30.01.2014, 10:05 -0800 schrieb Andy Lutomirski:
> >> On Thu, Jan 30, 2014 at 2:49 AM, <stefani@seibold.net> wrote:
> >> > diff --git a/arch/x86/include/asm/compat.h b/arch/x86/include/asm/compat.h
> >> > index 59c6c40..45ba688 100644
> >> > --- a/arch/x86/include/asm/compat.h
> >> > +++ b/arch/x86/include/asm/compat.h
> >> > @@ -295,6 +295,10 @@ static inline compat_uptr_t ptr_to_compat(void __user *uptr)
> >> >
> >> > static inline void __user *arch_compat_alloc_user_space(long len)
> >> > {
> >> > +#ifdef CONFIG_X86_32
> >> > + struct pt_regs *regs = task_pt_regs(current);
> >> > + return (void __user *)regs->sp - len;
> >>
> >> Is there some reason this doesn't need to be aligned?
> >>
> >
> > The reason is that this function will not used for 32 bit kernels, but
> > will the header will be included... This prevents an error!
>
> Then why not just guard the whole function with an ifdef? Having a
> piece of actual code that's not intended to be used (and might not
> work) seems like a bad idea.
>
Good point. I will do this in the next version.
next prev parent reply other threads:[~2014-01-30 20:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 10:49 [PATCH 0/4] Add 32 bit VDSO time function support stefani
2014-01-30 10:49 ` [PATCH 1/4] Make vsyscall_gtod_data handling x86 generic stefani
2014-01-30 18:05 ` Andy Lutomirski
2014-01-30 19:27 ` Stefani Seibold
2014-01-30 19:51 ` Andy Lutomirski
2014-01-30 20:19 ` Stefani Seibold [this message]
2014-01-31 0:10 ` Andi Kleen
2014-02-01 14:51 ` Stefani Seibold
2014-01-30 10:49 ` [PATCH 2/4] Add new func _install_special_mapping() to mmap.c stefani
2014-01-30 10:49 ` [PATCH 3/4] Add 32 bit VDSO support for 32 kernel stefani
2014-01-30 15:30 ` H. Peter Anvin
2014-01-30 15:53 ` Stefani Seibold
2014-01-30 18:17 ` Andy Lutomirski
2014-01-30 19:39 ` Stefani Seibold
2014-01-30 19:50 ` Andy Lutomirski
2014-01-30 10:49 ` [PATCH 4/4] Add 32 bit VDSO support for 64 kernel stefani
2014-01-30 18:21 ` Andy Lutomirski
2014-01-30 19:43 ` Stefani Seibold
2014-01-31 23:12 ` Andy Lutomirski
2014-01-30 15:31 ` [PATCH 0/4] Add 32 bit VDSO time function support H. Peter Anvin
2014-01-30 15:52 ` Stefani Seibold
2014-01-30 15:54 ` H. Peter Anvin
2014-01-30 17:57 ` Andy Lutomirski
2014-01-30 18:03 ` H. Peter Anvin
2014-01-30 18:08 ` Andy Lutomirski
2014-02-01 15:32 stefani
2014-02-01 15:32 ` [PATCH 1/4] Make vsyscall_gtod_data handling x86 generic stefani
2014-02-01 23:40 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391113152.1405.1.camel@wall-e.seibold.net \
--to=stefani@seibold.net \
--cc=Andreas.Brief@rohde-schwarz.com \
--cc=Martin.Runge@rohde-schwarz.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gorcunov@openvz.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome