mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefani Seibold <stefani@seibold.net>
To: Andi Kleen <ak@linux.intel.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	x86@kernel.org, tglx@linutronix.de, mingo@redhat.com,
	hpa@zytor.com, aarcange@redhat.com, john.stultz@linaro.org,
	luto@amacapital.net, xemul@parallels.com, gorcunov@openvz.org,
	andriy.shevchenko@linux.intel.com,
	Martin.Runge@rohde-schwarz.com, Andreas.Brief@rohde-schwarz.com
Subject: Re: [PATCH 1/4] Make vsyscall_gtod_data handling x86 generic
Date: Sat, 01 Feb 2014 15:51:24 +0100	[thread overview]
Message-ID: <1391266284.964.1.camel@wall-e.seibold.net> (raw)
In-Reply-To: <20140131001034.GB2350@tassilo.jf.intel.com>

Am Donnerstag, den 30.01.2014, 16:10 -0800 schrieb Andi Kleen:
> > @@ -1335,7 +1335,6 @@ config ARCH_SPARSEMEM_ENABLE
> >  
> >  config ARCH_SPARSEMEM_DEFAULT
> >  	def_bool y
> > -	depends on X86_64
> 
> Is that really needed? Why does the vdso need sparsemem?
> 

No, it is from the previous patch. I will fix it.

> >  
> >  static inline void __user *arch_compat_alloc_user_space(long len)
> >  {
> > +#ifdef CONFIG_X86_32
> > +	struct pt_regs *regs = task_pt_regs(current);
> > +	return (void __user *)regs->sp - len;
> > +#else
> >  	compat_uptr_t sp;
> 
> and that? why does a vdso need to allocate things on the user page?
> 

Will also fixed, compat.h will not longer include by vsyscall_gtod.c.



  reply	other threads:[~2014-02-01 14:50 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-30 10:49 [PATCH 0/4] Add 32 bit VDSO time function support stefani
2014-01-30 10:49 ` [PATCH 1/4] Make vsyscall_gtod_data handling x86 generic stefani
2014-01-30 18:05   ` Andy Lutomirski
2014-01-30 19:27     ` Stefani Seibold
2014-01-30 19:51       ` Andy Lutomirski
2014-01-30 20:19         ` Stefani Seibold
2014-01-31  0:10   ` Andi Kleen
2014-02-01 14:51     ` Stefani Seibold [this message]
2014-01-30 10:49 ` [PATCH 2/4] Add new func _install_special_mapping() to mmap.c stefani
2014-01-30 10:49 ` [PATCH 3/4] Add 32 bit VDSO support for 32 kernel stefani
2014-01-30 15:30   ` H. Peter Anvin
2014-01-30 15:53     ` Stefani Seibold
2014-01-30 18:17   ` Andy Lutomirski
2014-01-30 19:39     ` Stefani Seibold
2014-01-30 19:50       ` Andy Lutomirski
2014-01-30 10:49 ` [PATCH 4/4] Add 32 bit VDSO support for 64 kernel stefani
2014-01-30 18:21   ` Andy Lutomirski
2014-01-30 19:43     ` Stefani Seibold
2014-01-31 23:12       ` Andy Lutomirski
2014-01-30 15:31 ` [PATCH 0/4] Add 32 bit VDSO time function support H. Peter Anvin
2014-01-30 15:52   ` Stefani Seibold
2014-01-30 15:54     ` H. Peter Anvin
2014-01-30 17:57     ` Andy Lutomirski
2014-01-30 18:03       ` H. Peter Anvin
2014-01-30 18:08         ` Andy Lutomirski
2014-02-01 15:32 stefani
2014-02-01 15:32 ` [PATCH 1/4] Make vsyscall_gtod_data handling x86 generic stefani
2014-02-01 23:40   ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391266284.964.1.camel@wall-e.seibold.net \
    --to=stefani@seibold.net \
    --cc=Andreas.Brief@rohde-schwarz.com \
    --cc=Martin.Runge@rohde-schwarz.com \
    --cc=aarcange@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=gorcunov@openvz.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome