* Re: perf trace: Initial beautifier for ioctl's 'cmd' arg
@ 2014-02-05 9:53 Ben Hutchings
0 siblings, 0 replies; 2+ messages in thread
From: Ben Hutchings @ 2014-02-05 9:53 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Peter Zijlstra, Paul Mackerras, Ingo Molnar, LKML
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
Commit 78645cf3ed32860a3e83b8e35aa469f5b844a4ba introduced a build
failure on powerpc and sparc as it redefines TCGETS. TCGETS doesn't
actually appear to be used, but in any case these and many other
architectures give it a different value than 0x5401. In fact they have
mostly different numbering of tty ioctls, in two different ranges (type
byte may be 0x54 or 0x74).
Please do this properly (actually use the macros!) or revert it.
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: perf trace: Initial beautifier for ioctl's 'cmd' arg
@ 2014-02-05 9:53 Ben Hutchings
0 siblings, 0 replies; 2+ messages in thread
From: Ben Hutchings @ 2014-02-05 9:53 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Peter Zijlstra, Paul Mackerras, Ingo Molnar, LKML
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
Commit 78645cf3ed32860a3e83b8e35aa469f5b844a4ba introduced a build
failure on powerpc and sparc as it redefines TCGETS. TCGETS doesn't
actually appear to be used, but in any case these and many other
architectures give it a different value than 0x5401. In fact they have
mostly different numbering of tty ioctls, in two different ranges (type
byte may be 0x54 or 0x74).
Please do this properly (actually use the macros!) or revert it.
Ben.
--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-05 9:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-05 9:53 perf trace: Initial beautifier for ioctl's 'cmd' arg Ben Hutchings
-- strict thread matches above, loose matches on Subject: below --
2014-02-05 9:53 Ben Hutchings
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®