* [PATCH] media: i2c: Kconfig: create dependency to MEDIA_CONTROLLER for adv7*
@ 2014-02-05 15:56 Marcus Folkesson
2014-02-06 8:01 ` Prabhakar Lad
0 siblings, 1 reply; 2+ messages in thread
From: Marcus Folkesson @ 2014-02-05 15:56 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Hans Verkuil, prabhakar.csengg,
Martin Bugge, Sylwester Nawrocki
Cc: linux-media, linux-kernel, Marcus Folkesson
These chips makes use of the media_entity in the v4l2_subdev struct
and is therefor dependent of the MEDIA_CONTROLLER config.
Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
drivers/media/i2c/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index d18be19..1771b77 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -196,7 +196,7 @@ config VIDEO_ADV7183
config VIDEO_ADV7604
tristate "Analog Devices ADV7604 decoder"
- depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API
+ depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER
---help---
Support for the Analog Devices ADV7604 video decoder.
@@ -208,7 +208,7 @@ config VIDEO_ADV7604
config VIDEO_ADV7842
tristate "Analog Devices ADV7842 decoder"
- depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API
+ depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER
---help---
Support for the Analog Devices ADV7842 video decoder.
@@ -431,7 +431,7 @@ config VIDEO_ADV7393
config VIDEO_ADV7511
tristate "Analog Devices ADV7511 encoder"
- depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API
+ depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER
---help---
Support for the Analog Devices ADV7511 video encoder.
--
1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] media: i2c: Kconfig: create dependency to MEDIA_CONTROLLER for adv7*
2014-02-05 15:56 [PATCH] media: i2c: Kconfig: create dependency to MEDIA_CONTROLLER for adv7* Marcus Folkesson
@ 2014-02-06 8:01 ` Prabhakar Lad
0 siblings, 0 replies; 2+ messages in thread
From: Prabhakar Lad @ 2014-02-06 8:01 UTC (permalink / raw)
To: Marcus Folkesson
Cc: Mauro Carvalho Chehab, Hans Verkuil, Martin Bugge,
Sylwester Nawrocki, linux-media, LKML
Hi Marcus,
On Wed, Feb 5, 2014 at 9:26 PM, Marcus Folkesson
<marcus.folkesson@gmail.com> wrote:
> These chips makes use of the media_entity in the v4l2_subdev struct
> and is therefor dependent of the MEDIA_CONTROLLER config.
>
NAK, as you can currently see these drivers depend on VIDEO_V4L2_SUBDEV_API
config and if you see VIDEO_V4L2_SUBDEV_API depends on MEDIA_CONTROLLER
config so there is no point in adding this dependency.
Thanks,
--Prabhakar Lad
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> ---
> drivers/media/i2c/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index d18be19..1771b77 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -196,7 +196,7 @@ config VIDEO_ADV7183
>
> config VIDEO_ADV7604
> tristate "Analog Devices ADV7604 decoder"
> - depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API
> + depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER
> ---help---
> Support for the Analog Devices ADV7604 video decoder.
>
> @@ -208,7 +208,7 @@ config VIDEO_ADV7604
>
> config VIDEO_ADV7842
> tristate "Analog Devices ADV7842 decoder"
> - depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API
> + depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER
> ---help---
> Support for the Analog Devices ADV7842 video decoder.
>
> @@ -431,7 +431,7 @@ config VIDEO_ADV7393
>
> config VIDEO_ADV7511
> tristate "Analog Devices ADV7511 encoder"
> - depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API
> + depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER
> ---help---
> Support for the Analog Devices ADV7511 video encoder.
>
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-06 8:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-05 15:56 [PATCH] media: i2c: Kconfig: create dependency to MEDIA_CONTROLLER for adv7* Marcus Folkesson
2014-02-06 8:01 ` Prabhakar Lad
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome