* [PATCH] x86, sections, numachip: Remove useless __read_mostly
@ 2014-02-08 7:54 Andi Kleen
2014-02-08 10:29 ` David Rientjes
0 siblings, 1 reply; 2+ messages in thread
From: Andi Kleen @ 2014-02-08 7:54 UTC (permalink / raw)
To: x86; +Cc: linux-kernel, Andi Kleen
const __read_mostly does not make any sense, because const
data is already read-only. Remove the __read_mostly
for the numachip APIC driver. This avoids a LTO
section conflict compile problem.
Cc: x86@kernel.org
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
arch/x86/kernel/apic/apic_numachip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/apic/apic_numachip.c b/arch/x86/kernel/apic/apic_numachip.c
index 3e67f9e..a481bb6 100644
--- a/arch/x86/kernel/apic/apic_numachip.c
+++ b/arch/x86/kernel/apic/apic_numachip.c
@@ -32,7 +32,7 @@
static int numachip_system __read_mostly;
-static const struct apic apic_numachip __read_mostly;
+static const struct apic apic_numachip;
static unsigned int get_apic_id(unsigned long x)
{
--
1.8.5.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86, sections, numachip: Remove useless __read_mostly
2014-02-08 7:54 [PATCH] x86, sections, numachip: Remove useless __read_mostly Andi Kleen
@ 2014-02-08 10:29 ` David Rientjes
0 siblings, 0 replies; 2+ messages in thread
From: David Rientjes @ 2014-02-08 10:29 UTC (permalink / raw)
To: Andi Kleen; +Cc: x86, linux-kernel
On Sat, 8 Feb 2014, Andi Kleen wrote:
> const __read_mostly does not make any sense, because const
> data is already read-only. Remove the __read_mostly
> for the numachip APIC driver. This avoids a LTO
> section conflict compile problem.
>
> Cc: x86@kernel.org
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: David Rientjes <rientjes@google.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-08 10:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-08 7:54 [PATCH] x86, sections, numachip: Remove useless __read_mostly Andi Kleen
2014-02-08 10:29 ` David Rientjes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome