* [PATCH] mmc: omap_hsmmc: fix sparse/smatch warning for paranthesis
@ 2014-02-14 5:28 Nishanth Menon
0 siblings, 0 replies; only message in thread
From: Nishanth Menon @ 2014-02-14 5:28 UTC (permalink / raw)
To: Balaji T K, Chris Ball
Cc: linux-mmc, linux-omap, linux-kernel, Nishanth Menon
commit 6c31b21 (mmc: omap_hsmmc: remove access to SYSCONFIG register)
introduced an smatch(http://smatch.sf.net) warning for the following:
drivers/mmc/host/omap_hsmmc.c:608 omap_hsmmc_context_restore() warn: add
some parenthesis here?
drivers/mmc/host/omap_hsmmc.c:608 omap_hsmmc_context_restore() warn:
maybe use && instead of &
sparse reports:
drivers/mmc/host/omap_hsmmc.c: warning: dubious: !x & y
Fix the same.
Signed-off-by: Nishanth Menon <nm@ti.com>
---
drivers/mmc/host/omap_hsmmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index dbd32ad..575f9cc 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -605,7 +605,7 @@ static int omap_hsmmc_context_restore(struct omap_hsmmc_host *host)
u32 hctl, capa;
unsigned long timeout;
- if (!OMAP_HSMMC_READ(host->base, SYSSTATUS) & RESETDONE)
+ if (!(OMAP_HSMMC_READ(host->base, SYSSTATUS) & RESETDONE))
return 1;
if (host->con == OMAP_HSMMC_READ(host->base, CON) &&
--
1.7.9.5
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-02-14 5:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-14 5:28 [PATCH] mmc: omap_hsmmc: fix sparse/smatch warning for paranthesis Nishanth Menon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®