[PATCH] pfuze100-regulator: Fix of_node_get() parameter

[PATCH] pfuze100-regulator: Fix of_node_get() parameter

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

Since commit d7857c42 (regulator: pfuze100: Use of_get_child_by_name) we get
the following probe failure:

pfuze100-regulator 1-0008: Full layer: 1, Metal layer: 0                       
pfuze100-regulator 1-0008: FAB: 0, FIN: 0                                      
pfuze100-regulator 1-0008: regulators node not found                           
pfuze100-regulator: probe of 1-0008 failed with error -22 

Now that of_get_child_by_name() is used we should adjust the device_node pointer
'np' to not get the parent node anymore. 

Suggested-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/regulator/pfuze100-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c
index c1cb202..dcb03ce 100644
--- a/drivers/regulator/pfuze100-regulator.c
+++ b/drivers/regulator/pfuze100-regulator.c
@@ -250,7 +250,7 @@ static int pfuze_parse_regulators_dt(struct pfuze_chip *chip)
 	struct device_node *np, *parent;
 	int ret;
 
-	np = of_node_get(dev->parent->of_node);
+	np = of_node_get(dev->of_node);
 	if (!np)
 		return 0;
 
-- 
1.8.1.2

Re: [PATCH] pfuze100-regulator: Fix of_node_get() parameter

[Sachin Kamat]

On 19 February 2014 08:16, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Since commit d7857c42 (regulator: pfuze100: Use of_get_child_by_name) we get
> the following probe failure:
>
> pfuze100-regulator 1-0008: Full layer: 1, Metal layer: 0
> pfuze100-regulator 1-0008: FAB: 0, FIN: 0
> pfuze100-regulator 1-0008: regulators node not found
> pfuze100-regulator: probe of 1-0008 failed with error -22
>
> Now that of_get_child_by_name() is used we should adjust the device_node pointer
> 'np' to not get the parent node anymore.
>
> Suggested-by: Shawn Guo <shawn.guo@linaro.org>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Thanks for the fix Fabio.
Acked-by: Sachin Kamat <sachin.kamat@linaro.org>

Mark,
There are a few more instances that should be fixed like this one. How would you
prefer to handle them - Resend the complete patch or send just the
incremental fix?

-- 
With warm regards,
Sachin

Re: [PATCH] pfuze100-regulator: Fix of_node_get() parameter

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

On Tue, Feb 18, 2014 at 11:46:14PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Since commit d7857c42 (regulator: pfuze100: Use of_get_child_by_name) we get
> the following probe failure:

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] pfuze100-regulator: Fix of_node_get() parameter

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

On Wed, Feb 19, 2014 at 09:02:52AM +0530, Sachin Kamat wrote:

> There are a few more instances that should be fixed like this one. How would you
> prefer to handle them - Resend the complete patch or send just the
> incremental fix?

Incremental fixes always.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]