mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] scsi/sd.c: fix spun up and not ready messages to mention which disk
@ 2014-02-21  0:34 Stewart Smith
  0 siblings, 0 replies; only message in thread
From: Stewart Smith @ 2014-02-21  0:34 UTC (permalink / raw)
  To: James E.J. Bottomley, linux-scsi, linux-kernel; +Cc: Stewart Smith

Previously, many years ago, this was done in series which was fine,
but things moved to be done in parallel and with many disks in a system
it can be hard to see which disk spun up and which one didn't as the
printk messages were all mixed together.

Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
---
 drivers/scsi/sd.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 470954a..1436c85 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -1838,7 +1838,6 @@ sd_spinup_disk(struct scsi_disk *sdkp)
 			}
 			/* Wait 1 second for next try */
 			msleep(1000);
-			printk(".");
 
 		/*
 		 * Wait for USB flash devices with slow firmware.
@@ -1868,9 +1867,9 @@ sd_spinup_disk(struct scsi_disk *sdkp)
 
 	if (spintime) {
 		if (scsi_status_is_good(the_result))
-			printk("ready\n");
+			sd_printk(KERN_NOTICE, sdkp, "ready\n");
 		else
-			printk("not responding...\n");
+			sd_printk(KERN_NOTICE, sdkp, "not responding...\n");
 	}
 }
 
-- 
1.8.5.3


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-02-21  0:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-21  0:34 [PATCH] scsi/sd.c: fix spun up and not ready messages to mention which disk Stewart Smith

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®