From: Soren Brinkmann <soren.brinkmann@xilinx.com>
To: Russell King <linux@arm.linux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>
Cc: Michal Simek <michal.simek@xilinx.com>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org, Olof Johansson <olof@lixom.net>,
Arnd Bergmann <arnd@arndb.de>, Kevin Hilman <khilman@linaro.org>,
Soren Brinkmann <soren.brinkmann@xilinx.com>
Subject: [PATCH RFC 0/6] tty: xuartps renaming
Date: Tue, 4 Mar 2014 09:17:23 -0800 [thread overview]
Message-ID: <1393953449-28551-1-git-send-email-soren.brinkmann@xilinx.com> (raw)
Hi,
this series appears a little messy.
The UART controller in Zynq is Cadence vendor IP. Hence, naming and
identifying this properly would facilitate usage of this driver by other
implementers of this IP. Though, this might sound nice, there are some
details about this series, I am not sure whether they are acceptable:
- the device node name: It currently is 'ttyPS'. I don't know if there
are any rules regarding this and whether this should be changed or
not.
- the UART port #define in include/uapi/linux/serial_core.h is changed
- the series does not cleanly migrate Zynq (which is the only user of
this driver) to the new driver. There is broken UART between the
patches 'tty: Rename xilinx_uart -> cadence_uart' and 'ARM: zynq: DT:
Migrate UART to Cadence binding'. This is mostly due to a change of
the clock names which are used in the DT binding. It might be
possible to make the new and legacy names work, but it would look
rather ugly and since this should affect Zynq only, I hope to get
away with this.
I keep the CC list for the RFC a little reduced, in particular I leave
out the OF people. I think the fundamental questions are in the tty
field and probably ARM. The binding should not be a major problem since
it is essentially used already - it's just missing documentation.
Thanks,
Sören
Soren Brinkmann (6):
tty: xemacps: Clean up
tty: xemacps: Print warning in clock notifier
tty: Rename xilinx_uart -> cadence_uart
tty: cadence: Document DT binding
ARM: zynq: DT: Migrate UART to Cadence binding
ARM: multi_v7_defconfig: Adopt to UART driver renaming
.../devicetree/bindings/serial/cadence_uart.txt | 20 +
arch/arm/boot/dts/zynq-7000.dtsi | 8 +-
arch/arm/configs/multi_v7_defconfig | 4 +-
drivers/tty/serial/Kconfig | 15 +-
drivers/tty/serial/Makefile | 2 +-
drivers/tty/serial/cadence_uart.c | 1457 +++++++++++++++++++
drivers/tty/serial/xilinx_uartps.c | 1524 --------------------
include/uapi/linux/serial_core.h | 4 +-
8 files changed, 1494 insertions(+), 1540 deletions(-)
create mode 100644 Documentation/devicetree/bindings/serial/cadence_uart.txt
create mode 100644 drivers/tty/serial/cadence_uart.c
delete mode 100644 drivers/tty/serial/xilinx_uartps.c
--
1.9.0.1.g4196000
next reply other threads:[~2014-03-04 18:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 17:17 Soren Brinkmann [this message]
2014-03-04 17:17 ` [PATCH RFC 1/6] tty: xemacps: Clean up Soren Brinkmann
2014-03-04 17:17 ` [PATCH RFC 2/6] tty: xemacps: Print warning in clock notifier Soren Brinkmann
2014-03-04 17:17 ` [PATCH RFC 3/6] tty: Rename xilinx_uart -> cadence_uart Soren Brinkmann
2014-03-04 19:39 ` One Thousand Gnomes
2014-03-04 22:16 ` Arnd Bergmann
2014-03-05 18:22 ` Sören Brinkmann
2014-03-04 17:17 ` [PATCH RFC 4/6] tty: cadence: Document DT binding Soren Brinkmann
2014-03-04 17:17 ` [PATCH RFC 5/6] ARM: zynq: DT: Migrate UART to Cadence binding Soren Brinkmann
2014-03-04 17:17 ` [PATCH RFC 6/6] ARM: multi_v7_defconfig: Adopt to UART driver renaming Soren Brinkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393953449-28551-1-git-send-email-soren.brinkmann@xilinx.com \
--to=soren.brinkmann@xilinx.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=michal.simek@xilinx.com \
--cc=olof@lixom.net \
--cc=peter.crosthwaite@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®