From: Soren Brinkmann <soren.brinkmann@xilinx.com>
To: Russell King <linux@arm.linux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>
Cc: Michal Simek <michal.simek@xilinx.com>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org, Olof Johansson <olof@lixom.net>,
Arnd Bergmann <arnd@arndb.de>, Kevin Hilman <khilman@linaro.org>,
Soren Brinkmann <soren.brinkmann@xilinx.com>
Subject: [PATCH RFC 2/6] tty: xemacps: Print warning in clock notifier
Date: Tue, 4 Mar 2014 09:17:25 -0800 [thread overview]
Message-ID: <1393953449-28551-3-git-send-email-soren.brinkmann@xilinx.com> (raw)
In-Reply-To: <1393953449-28551-1-git-send-email-soren.brinkmann@xilinx.com>
Print a warning if the clock notifier rejects a clock frequency change
to facilitate debugging (see:
http://thread.gmane.org/gmane.linux.ports.arm.kernel/304329/focus=304379)
Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
drivers/tty/serial/xilinx_uartps.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index 8769b68534b1..4eee8031ae25 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -430,8 +430,10 @@ static int xuartps_clk_notifier_cb(struct notifier_block *nb,
* frequency.
*/
if (!xuartps_calc_baud_divs(ndata->new_rate, xuartps->baud,
- &bdiv, &cd, &div8))
+ &bdiv, &cd, &div8)) {
+ dev_warn(port->dev, "clock rate change rejected\n");
return NOTIFY_BAD;
+ }
spin_lock_irqsave(&xuartps->port->lock, flags);
--
1.9.0.1.g4196000
next prev parent reply other threads:[~2014-03-04 18:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 17:17 [PATCH RFC 0/6] tty: xuartps renaming Soren Brinkmann
2014-03-04 17:17 ` [PATCH RFC 1/6] tty: xemacps: Clean up Soren Brinkmann
2014-03-04 17:17 ` Soren Brinkmann [this message]
2014-03-04 17:17 ` [PATCH RFC 3/6] tty: Rename xilinx_uart -> cadence_uart Soren Brinkmann
2014-03-04 19:39 ` One Thousand Gnomes
2014-03-04 22:16 ` Arnd Bergmann
2014-03-05 18:22 ` Sören Brinkmann
2014-03-04 17:17 ` [PATCH RFC 4/6] tty: cadence: Document DT binding Soren Brinkmann
2014-03-04 17:17 ` [PATCH RFC 5/6] ARM: zynq: DT: Migrate UART to Cadence binding Soren Brinkmann
2014-03-04 17:17 ` [PATCH RFC 6/6] ARM: multi_v7_defconfig: Adopt to UART driver renaming Soren Brinkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393953449-28551-3-git-send-email-soren.brinkmann@xilinx.com \
--to=soren.brinkmann@xilinx.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=michal.simek@xilinx.com \
--cc=olof@lixom.net \
--cc=peter.crosthwaite@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®