* [PATCH v2 2/2] usb: Make DELAY_INIT quirk wait 100ms between Get Configuration requests
@ 2014-03-04 19:27 Julius Werner
0 siblings, 0 replies; only message in thread
From: Julius Werner @ 2014-03-04 19:27 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Oliver Neukum, Luigi Semenzato, linux-kernel, linux-usb, Julius Werner
The DELAY_INIT quirk only reduces the frequency of enumeration failures
with the Logitech HD Pro C920 and C930e webcams, but does not quite
eliminate them. We have found that adding a delay of 100ms between the
first and second Get Configuration request makes the device enumerate
perfectly reliable even after several weeks of extensive testing. The
reasons for that are anyone's guess, but since the DELAY_INIT quirk
already delays enumeration by a whole second, wating for another 10th of
that isn't really a big deal for the one other device that uses it, and
it will resolve the problems with these webcams.
Signed-off-by: Julius Werner <jwerner@chromium.org>
---
drivers/usb/core/config.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
index 8d72f0c..062967c 100644
--- a/drivers/usb/core/config.c
+++ b/drivers/usb/core/config.c
@@ -717,6 +717,10 @@ int usb_get_configuration(struct usb_device *dev)
result = -ENOMEM;
goto err;
}
+
+ if (dev->quirks & USB_QUIRK_DELAY_INIT)
+ msleep(100);
+
result = usb_get_descriptor(dev, USB_DT_CONFIG, cfgno,
bigbuffer, length);
if (result < 0) {
--
1.8.3.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-03-04 19:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-04 19:27 [PATCH v2 2/2] usb: Make DELAY_INIT quirk wait 100ms between Get Configuration requests Julius Werner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®