From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Felipe Balbi <balbi@ti.com>
Cc: "Ivan T. Ivanov" <iivanov@mm-sol.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: [PATCH v5 10/14] usb: phy: msm: Use reset framework for LINK and PHY resets
Date: Wed, 5 Mar 2014 12:13:46 +0200 [thread overview]
Message-ID: <1394014430-26485-11-git-send-email-iivanov@mm-sol.com> (raw)
In-Reply-To: <1394014430-26485-1-git-send-email-iivanov@mm-sol.com>
From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com>
---
drivers/usb/phy/phy-msm-usb.c | 30 ++++++++++++++++++++++--------
include/linux/usb/msm_hsusb.h | 3 +++
2 files changed, 25 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
index 298820f..7e5c4ab 100644
--- a/drivers/usb/phy/phy-msm-usb.c
+++ b/drivers/usb/phy/phy-msm-usb.c
@@ -32,6 +32,7 @@
#include <linux/pm_runtime.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/reset.h>
#include <linux/usb.h>
#include <linux/usb/otg.h>
@@ -235,12 +236,16 @@ static void ulpi_init(struct msm_otg *motg)
static int msm_otg_link_clk_reset(struct msm_otg *motg, bool assert)
{
- int ret = 0;
+ int ret;
- if (!motg->pdata->link_clk_reset)
- return ret;
+ if (motg->pdata->link_clk_reset)
+ ret = motg->pdata->link_clk_reset(motg->clk, assert);
+ else
+ if (assert)
+ ret = reset_control_assert(motg->link_rst);
+ else
+ ret = reset_control_deassert(motg->link_rst);
- ret = motg->pdata->link_clk_reset(motg->clk, assert);
if (ret)
dev_err(motg->phy.dev, "usb link clk reset %s failed\n",
assert ? "assert" : "deassert");
@@ -250,12 +255,13 @@ static int msm_otg_link_clk_reset(struct msm_otg *motg, bool assert)
static int msm_otg_phy_clk_reset(struct msm_otg *motg)
{
- int ret = 0;
+ int ret;
- if (!motg->pdata->phy_clk_reset)
- return ret;
+ if (motg->pdata->phy_clk_reset)
+ ret = motg->pdata->phy_clk_reset(motg->phy_reset_clk);
+ else
+ ret = reset_control_reset(motg->phy_rst);
- ret = motg->pdata->phy_clk_reset(motg->phy_reset_clk);
if (ret)
dev_err(motg->phy.dev, "usb phy clk reset failed\n");
@@ -1374,6 +1380,14 @@ static int msm_otg_read_dt(struct platform_device *pdev, struct msm_otg *motg)
id = of_match_device(msm_otg_dt_match, &pdev->dev);
pdata->phy_type = (int) id->data;
+ motg->link_rst = devm_reset_control_get(&pdev->dev, "link");
+ if (IS_ERR(motg->link_rst))
+ return PTR_ERR(motg->link_rst);
+
+ motg->phy_rst = devm_reset_control_get(&pdev->dev, "phy");
+ if (IS_ERR(motg->phy_rst))
+ return PTR_ERR(motg->phy_rst);
+
pdata->mode = of_usb_get_dr_mode(node);
if (pdata->mode == USB_DR_MODE_UNKNOWN)
pdata->mode = USB_DR_MODE_OTG;
diff --git a/include/linux/usb/msm_hsusb.h b/include/linux/usb/msm_hsusb.h
index bd68299..4e5d916 100644
--- a/include/linux/usb/msm_hsusb.h
+++ b/include/linux/usb/msm_hsusb.h
@@ -165,6 +165,9 @@ struct msm_otg {
struct regulator *v3p3;
struct regulator *v1p8;
struct regulator *vddcx;
+
+ struct reset_control *phy_rst;
+ struct reset_control *link_rst;
};
#endif
--
1.7.9.5
next prev parent reply other threads:[~2014-03-05 10:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 10:13 [PATCH v5 00/14] usb: phy: msm: Fixes, cleanups and DT support Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 01/14] usb: phy: msm: Move global regulators variables to driver state Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 02/14] usb: phy: msm: Migrate to Managed Device Resource allocation Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 03/14] usb: phy: msm: Remove unnecessarily check for valid regulators Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 04/14] usb: phy: msm: Fix checkpatch.pl warnings Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 05/14] usb: phy: msm: Replace custom enum usb_mode_type with enum usb_dr_mode Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 06/14] usb: phy: msm: Remove unused pclk_src_name Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 07/14] usb: phy: msm: Remove HSUSB prefix from regulator names Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 08/14] usb: phy: msm: Properly check result from platform_get_irq() Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 09/14] usb: phy: msm: Add device tree support and binding information Ivan T. Ivanov
2014-03-05 10:13 ` Ivan T. Ivanov [this message]
2014-03-05 12:34 ` [PATCH v5 10/14] usb: phy: msm: Use reset framework for LINK and PHY resets Sergei Shtylyov
2014-03-06 16:35 ` Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 11/14] usb: phy: msm: Add support for secondary PHY control Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 12/14] usb: phy: msm: Correct USB PHY Reset sequence for newer platform Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 13/14] usb: phy: msm: Handle disconnect events Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 14/14] usb: phy: msm: Vote for corner of VDD CX instead of voltage of VDD CX Ivan T. Ivanov
2014-03-06 1:54 ` [PATCH v5 00/14] usb: phy: msm: Fixes, cleanups and DT support Tim Bird
2014-03-08 0:15 ` Felipe Balbi
2014-03-08 16:46 ` Ivan T. Ivanov
2014-03-10 18:36 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394014430-26485-11-git-send-email-iivanov@mm-sol.com \
--to=iivanov@mm-sol.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®