From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Felipe Balbi <balbi@ti.com>
Cc: "Ivan T. Ivanov" <iivanov@mm-sol.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: [PATCH v5 08/14] usb: phy: msm: Properly check result from platform_get_irq()
Date: Wed, 5 Mar 2014 12:13:44 +0200 [thread overview]
Message-ID: <1394014430-26485-9-git-send-email-iivanov@mm-sol.com> (raw)
In-Reply-To: <1394014430-26485-1-git-send-email-iivanov@mm-sol.com>
From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Function return negative code on error.
Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com>
---
drivers/usb/phy/phy-msm-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
index c2048c7..31fb916 100644
--- a/drivers/usb/phy/phy-msm-usb.c
+++ b/drivers/usb/phy/phy-msm-usb.c
@@ -1412,7 +1412,7 @@ static int __init msm_otg_probe(struct platform_device *pdev)
dev_info(&pdev->dev, "OTG regs = %p\n", motg->regs);
motg->irq = platform_get_irq(pdev, 0);
- if (!motg->irq) {
+ if (motg->irq < 0) {
dev_err(&pdev->dev, "platform_get_irq failed\n");
return motg->irq;
}
--
1.7.9.5
next prev parent reply other threads:[~2014-03-05 10:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 10:13 [PATCH v5 00/14] usb: phy: msm: Fixes, cleanups and DT support Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 01/14] usb: phy: msm: Move global regulators variables to driver state Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 02/14] usb: phy: msm: Migrate to Managed Device Resource allocation Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 03/14] usb: phy: msm: Remove unnecessarily check for valid regulators Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 04/14] usb: phy: msm: Fix checkpatch.pl warnings Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 05/14] usb: phy: msm: Replace custom enum usb_mode_type with enum usb_dr_mode Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 06/14] usb: phy: msm: Remove unused pclk_src_name Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 07/14] usb: phy: msm: Remove HSUSB prefix from regulator names Ivan T. Ivanov
2014-03-05 10:13 ` Ivan T. Ivanov [this message]
2014-03-05 10:13 ` [PATCH v5 09/14] usb: phy: msm: Add device tree support and binding information Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 10/14] usb: phy: msm: Use reset framework for LINK and PHY resets Ivan T. Ivanov
2014-03-05 12:34 ` Sergei Shtylyov
2014-03-06 16:35 ` Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 11/14] usb: phy: msm: Add support for secondary PHY control Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 12/14] usb: phy: msm: Correct USB PHY Reset sequence for newer platform Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 13/14] usb: phy: msm: Handle disconnect events Ivan T. Ivanov
2014-03-05 10:13 ` [PATCH v5 14/14] usb: phy: msm: Vote for corner of VDD CX instead of voltage of VDD CX Ivan T. Ivanov
2014-03-06 1:54 ` [PATCH v5 00/14] usb: phy: msm: Fixes, cleanups and DT support Tim Bird
2014-03-08 0:15 ` Felipe Balbi
2014-03-08 16:46 ` Ivan T. Ivanov
2014-03-10 18:36 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394014430-26485-9-git-send-email-iivanov@mm-sol.com \
--to=iivanov@mm-sol.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®