mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Choi Gi-yong <yong@gnoy.org>
Cc: tj@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: Changed pr_warning() to pr_warn()
Date: Fri, 07 Mar 2014 20:00:14 -0800	[thread overview]
Message-ID: <1394251214.6972.20.camel@joe-AO722> (raw)
In-Reply-To: <1394250681-5258-1-git-send-email-yong@gnoy.org>

On Sat, 2014-03-08 at 12:51 +0900, Choi Gi-yong wrote:

> diff --git a/mm/percpu.c b/mm/percpu.c
[]
> @@ -813,7 +813,7 @@ fail_unlock:
>  fail_unlock_mutex:
>  	mutex_unlock(&pcpu_alloc_mutex);
>  	if (warn_limit) {
> -		pr_warning("PERCPU: allocation failed, size=%zu align=%zu, "
> +		pr_warn("PERCPU: allocation failed, size=%zu align=%zu, "
>  			   "%s\n", size, align, err);

If you're going do to this, please coalesce
the format fragments.

		pr_warn("PERCPU: allocation failed, size=%zu align=%zu, %s\n",
			size, align, err);

> @@ -1690,7 +1690,7 @@ int __init pcpu_embed_first_chunk(size_t reserved_size, size_t dyn_size,
>  
>  	/* warn if maximum distance is further than 75% of vmalloc space */
>  	if (max_distance > VMALLOC_TOTAL * 3 / 4) {
> -		pr_warning("PERCPU: max_distance=0x%zx too large for vmalloc "
> +		pr_warn("PERCPU: max_distance=0x%zx too large for vmalloc "
>  			   "space 0x%lx\n", max_distance,
>  			   VMALLOC_TOTAL);

here too

		pr_warn("PERCPU: max_distance=0x%zx too large for vmalloc space 0x%lx\n",
			max_distance, VMALLOC_TOTAL);

> @@ -1774,7 +1774,7 @@ int __init pcpu_page_first_chunk(size_t reserved_size,
>  
>  			ptr = alloc_fn(cpu, PAGE_SIZE, PAGE_SIZE);
>  			if (!ptr) {
> -				pr_warning("PERCPU: failed to allocate %s page "
> +				pr_warn("PERCPU: failed to allocate %s page "
>  					   "for cpu%u\n", psize_str, cpu);

etc.



  reply	other threads:[~2014-03-08  4:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-08  3:51 Choi Gi-yong
2014-03-08  4:00 ` Joe Perches [this message]
2014-03-09  8:15 Choi Gi-yong
2014-03-09 22:15 ` Joe Perches
2014-03-13  0:33   ` 최(Choi)기용(Gi-yong)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394251214.6972.20.camel@joe-AO722 \
    --to=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=yong@gnoy.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®