From: Joe Perches <joe@perches.com>
To: Choi Gi-yong <yong@gnoy.org>
Cc: tj@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: Changed pr_warning() to pr_warn()
Date: Sun, 09 Mar 2014 15:15:55 -0700 [thread overview]
Message-ID: <1394403355.30791.3.camel@joe-AO722> (raw)
In-Reply-To: <1394352900-13629-1-git-send-email-yong@gnoy.org>
On Sun, 2014-03-09 at 17:15 +0900, Choi Gi-yong wrote:
> Signed-off-by: Choi Gi-yong <yong@gnoy.org>
[]
> diff --git a/mm/percpu.c b/mm/percpu.c
> @@ -812,8 +812,8 @@ fail_unlock:
> fail_unlock_mutex:
> mutex_unlock(&pcpu_alloc_mutex);
> if (warn_limit) {
> - pr_warn("PERCPU: allocation failed, size=%zu align=%zu, "
> - "%s\n", size, align, err);
> + pr_warn("PERCPU: allocation failed, size=%zu align=%zu, %s\n",
> + size, align, err);
The second line should use 3 tabs for indentation.
pr_warn("PERCPU: allocation failed, size=%zu align=%zu, %s\n",
size, align, err);
If you want to become familiar with kernel style
and patching something, please practice on some
files in drivers/staging.
next prev parent reply other threads:[~2014-03-09 22:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-09 8:15 Choi Gi-yong
2014-03-09 22:15 ` Joe Perches [this message]
2014-03-13 0:33 ` 최(Choi)기용(Gi-yong)
-- strict thread matches above, loose matches on Subject: below --
2014-03-08 3:51 Choi Gi-yong
2014-03-08 4:00 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394403355.30791.3.camel@joe-AO722 \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yong@gnoy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®