From: Ben Hutchings <ben@decadent.org.uk>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-kernel@vger.kernel.org,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>, John Kacur <jkacur@redhat.com>,
Corey Minyard <cminyard@mvista.com>
Subject: Re: [PATCH RT 2/5] a few open coded completions
Date: Wed, 12 Mar 2014 18:15:28 +0000 [thread overview]
Message-ID: <1394648128.23624.32.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <20140311115420.4904b7ed@gandalf.local.home>
[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]
On Tue, 2014-03-11 at 11:54 -0400, Steven Rostedt wrote:
> On Mon, 10 Mar 2014 22:56:23 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
>
> > Thanks, I ran an allmodconfig, and you're right, the orinoco driver
> > failed to compile on v3.2-rt. I ran allmodconfig on 3.10-rt and it
> > passed fine. Seems that one of the headers there pulls in swait.
> >
> > Looking deeper, 3.10-rt has completion as a simple-wait, and
> > completion.h pulls in wait-simple.h, which is why it works there. 3.2
> > does not have completions there. I wonder if I should pull in the patch
> > that converts completions into swaits, and that may fix other locations
> > as well.
>
> The swait code for 3.2 can't even handle the changes that were made.
> That is, the patch used swait functions not created in 3.2-rt.
>
> I'll just revert those from 3.2-rt and be done with it.
>
> Thanks for the report.
OK. Sorry for the 'WTF'; now I understand that this was a build fix for
the later branches.
Ben.
--
Ben Hutchings
Any sufficiently advanced bug is indistinguishable from a feature.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next prev parent reply other threads:[~2014-03-12 18:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 0:37 [PATCH RT 0/5] Linux 3.10.22-rt20-rc1 Steven Rostedt
2013-12-11 0:37 ` [PATCH RT 1/5] cpu_down: move migrate_enable() back Steven Rostedt
2013-12-11 0:37 ` [PATCH RT 2/5] a few open coded completions Steven Rostedt
2013-12-11 14:25 ` Corey Minyard
2013-12-11 15:34 ` Steven Rostedt
2013-12-15 15:28 ` Sebastian Andrzej Siewior
2013-12-15 21:08 ` Steven Rostedt
2013-12-11 19:49 ` Steven Rostedt
2014-03-09 0:27 ` Ben Hutchings
2014-03-10 14:29 ` Steven Rostedt
2014-03-10 17:52 ` Ben Hutchings
2014-03-10 18:14 ` Steven Rostedt
2014-03-11 2:06 ` Ben Hutchings
2014-03-11 2:56 ` Steven Rostedt
2014-03-11 15:54 ` Steven Rostedt
2014-03-12 18:15 ` Ben Hutchings [this message]
2013-12-11 0:37 ` [PATCH RT 3/5] lockdep: Correctly annotate hardirq context in irq_exit() Steven Rostedt
2013-12-11 0:37 ` [PATCH RT 4/5] rtmutex: use a trylock for waiter lock in trylock Steven Rostedt
2013-12-11 0:37 ` [PATCH RT 5/5] Linux 3.10.22-rt20-rc1 Steven Rostedt
2013-12-11 0:46 [PATCH RT 0/5] Linux 3.8.13.13-rt26-rc1 Steven Rostedt
2013-12-11 0:46 ` [PATCH RT 2/5] a few open coded completions Steven Rostedt
2013-12-11 19:54 ` Steven Rostedt
2013-12-11 0:50 [PATCH RT 0/5] Linux 3.4.72-rt90-rc1 Steven Rostedt
2013-12-11 0:50 ` [PATCH RT 2/5] a few open coded completions Steven Rostedt
2013-12-11 19:57 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394648128.23624.32.camel@deadeye.wl.decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=C.Emde@osadl.org \
--cc=bigeasy@linutronix.de \
--cc=cminyard@mvista.com \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®