* [PATCH net] r8152: fix the list rx_done may be used without initialization
[not found] <20170313215714.n2p6j4nxtpxbheaj@dell5510>
@ 2017-03-14 6:15 ` Hayes Wang
2017-03-21 21:37 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Hayes Wang @ 2017-03-14 6:15 UTC (permalink / raw)
To: netdev, petr.vorel; +Cc: nic_swsd, linux-kernel, linux-usb, Hayes Wang
The list rx_done would be initialized when the linking on occurs.
Therefore, if a napi is scheduled without any linking on before,
the following kernel panic would happen.
BUG: unable to handle kernel NULL pointer dereference at 000000000000008
IP: [<ffffffffc085efde>] r8152_poll+0xe1e/0x1210 [r8152]
PGD 0
Oops: 0002 [#1] SMP
Signed-off-by: Hayes Wang <hayeswang@realtek.com>
---
drivers/net/usb/r8152.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 986243c..bb3eedd 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -1362,6 +1362,7 @@ static int alloc_all_mem(struct r8152 *tp)
spin_lock_init(&tp->rx_lock);
spin_lock_init(&tp->tx_lock);
INIT_LIST_HEAD(&tp->tx_free);
+ INIT_LIST_HEAD(&tp->rx_done);
skb_queue_head_init(&tp->tx_queue);
skb_queue_head_init(&tp->rx_queue);
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH net] r8152: fix the list rx_done may be used without initialization
2017-03-14 6:15 ` [PATCH net] r8152: fix the list rx_done may be used without initialization Hayes Wang
@ 2017-03-21 21:37 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-03-21 21:37 UTC (permalink / raw)
To: hayeswang; +Cc: netdev, petr.vorel, nic_swsd, linux-kernel, linux-usb
From: Hayes Wang <hayeswang@realtek.com>
Date: Tue, 14 Mar 2017 14:15:20 +0800
> The list rx_done would be initialized when the linking on occurs.
> Therefore, if a napi is scheduled without any linking on before,
> the following kernel panic would happen.
>
> BUG: unable to handle kernel NULL pointer dereference at 000000000000008
> IP: [<ffffffffc085efde>] r8152_poll+0xe1e/0x1210 [r8152]
> PGD 0
> Oops: 0002 [#1] SMP
>
> Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-21 21:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20170313215714.n2p6j4nxtpxbheaj@dell5510>
2017-03-14 6:15 ` [PATCH net] r8152: fix the list rx_done may be used without initialization Hayes Wang
2017-03-21 21:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®