From: Andi Kleen <andi@firstfloor.org>
To: mingo@kernel.org
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
eranian@google.com, acme@redhat.com, namhyung@kernel.org,
jolsa@redhat.com, Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 2/2] perf, x86: Don't mark DataLA addresses as store
Date: Thu, 13 Mar 2014 14:22:13 -0700 [thread overview]
Message-ID: <1394745733-27855-2-git-send-email-andi@firstfloor.org> (raw)
In-Reply-To: <1394745733-27855-1-git-send-email-andi@firstfloor.org>
From: Andi Kleen <ak@linux.intel.com>
Haswell supports reporting the data address for a range
of events, including UOPS_RETIRED.ALL and some load
events. Currently these addresses were always marked
as stores, which is wrong, as they could be loads too.
Change it to NA instead.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
arch/x86/kernel/cpu/perf_event_intel_ds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/perf_event_intel_ds.c b/arch/x86/kernel/cpu/perf_event_intel_ds.c
index 77bdb09..7a319cf 100644
--- a/arch/x86/kernel/cpu/perf_event_intel_ds.c
+++ b/arch/x86/kernel/cpu/perf_event_intel_ds.c
@@ -113,7 +113,7 @@ static u64 precise_store_data_hsw(u64 status)
union perf_mem_data_src dse;
dse.val = 0;
- dse.mem_op = PERF_MEM_OP_STORE;
+ dse.mem_op = PERF_MEM_OP_NA;
dse.mem_lvl = PERF_MEM_LVL_NA;
if (status & 1)
dse.mem_lvl = PERF_MEM_LVL_L1;
--
1.8.5.3
next prev parent reply other threads:[~2014-03-13 21:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 21:22 [PATCH 1/2] perf, x86: Disallow setting undefined bits for PEBS events Andi Kleen
2014-03-13 21:22 ` Andi Kleen [this message]
2014-03-14 8:13 ` Peter Zijlstra
2014-03-14 13:54 ` Andi Kleen
2014-03-14 16:21 ` Peter Zijlstra
2014-07-07 22:37 [PATCH 1/2] perf, x86: Revamp PEBS event selection v2 Andi Kleen
2014-07-07 22:37 ` [PATCH 2/2] perf, x86: Don't mark DataLA addresses as store Andi Kleen
2014-07-12 0:01 [PATCH 1/2] perf, x86: Revamp PEBS event selection Andi Kleen
2014-07-12 0:01 ` [PATCH 2/2] perf, x86: Don't mark DataLA addresses as store Andi Kleen
2014-07-14 18:04 ` Stephane Eranian
2014-07-14 19:24 ` Andi Kleen
2014-07-14 22:08 ` Stephane Eranian
2014-07-14 22:39 ` Andi Kleen
2014-07-14 22:49 ` Stephane Eranian
2014-07-14 22:50 ` Stephane Eranian
2014-07-15 4:05 ` Andi Kleen
2014-07-15 8:59 ` Peter Zijlstra
2014-07-15 18:19 ` Stephane Eranian
2014-07-17 20:24 ` Stephane Eranian
2014-07-19 0:49 ` Andi Kleen
2014-07-21 21:15 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394745733-27855-2-git-send-email-andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome