From: Andi Kleen <ak@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>,
mingo@kernel.org, linux-kernel@vger.kernel.org,
eranian@google.com, acme@redhat.com, namhyung@kernel.org,
jolsa@redhat.com
Subject: Re: [PATCH 1/2] perf, x86: Disallow setting undefined bits for PEBS events
Date: Fri, 14 Mar 2014 06:54:39 -0700 [thread overview]
Message-ID: <20140314135439.GD3793@tassilo.jf.intel.com> (raw)
In-Reply-To: <20140314081338.GL27965@twins.programming.kicks-ass.net>
On Fri, Mar 14, 2014 at 09:13:38AM +0100, Peter Zijlstra wrote:
> On Thu, Mar 13, 2014 at 02:22:12PM -0700, Andi Kleen wrote:
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > The SDM forbids setting various event qualifiers with PEBS
> > events. The magic cycles:pp event uses it, but it has caused
> > problems in the past. We continue allowing it for cycles:pp,
> > but forbid it for all other events to follow the SDM.
>
> Last time this came up I asked for what kind of problems it caused.
The original PEBS lockup on Sandy Bridge was caused by these bits.
The person who architected the hardware strongly advised to not
use them with PEBS events.
Besides we do what the SDM tells us to do. Do you disagree
with that?
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2014-03-14 13:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 21:22 Andi Kleen
2014-03-13 21:22 ` [PATCH 2/2] perf, x86: Don't mark DataLA addresses as store Andi Kleen
2014-03-14 8:13 ` [PATCH 1/2] perf, x86: Disallow setting undefined bits for PEBS events Peter Zijlstra
2014-03-14 13:54 ` Andi Kleen [this message]
2014-03-14 16:21 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140314135439.GD3793@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome