* [PATCH] procfs: make smp_affinity values 0644
@ 2014-03-14 2:05 Chema Gonzalez
2014-03-14 2:37 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: Chema Gonzalez @ 2014-03-14 2:05 UTC (permalink / raw)
To: Thomas Gleixner, Eric Dumazet; +Cc: linux-kernel, Chema Gonzalez
Includes:
- /proc/irq/default_smp_affinity
- /proc/irq/*/smp_affinity
- /proc/irq/*/smp_affinity_list
Users can distill the same information by reading /proc/interrupts.
Signed-off-by: Chema Gonzalez <chema@google.com>
---
kernel/irq/proc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/irq/proc.c b/kernel/irq/proc.c
index 36f6ee1..3f80a9a 100644
--- a/kernel/irq/proc.c
+++ b/kernel/irq/proc.c
@@ -324,7 +324,7 @@ void register_irq_proc(unsigned int irq, struct irq_desc *desc)
#ifdef CONFIG_SMP
/* create /proc/irq/<irq>/smp_affinity */
- proc_create_data("smp_affinity", 0600, desc->dir,
+ proc_create_data("smp_affinity", 0644, desc->dir,
&irq_affinity_proc_fops, (void *)(long)irq);
/* create /proc/irq/<irq>/affinity_hint */
@@ -332,7 +332,7 @@ void register_irq_proc(unsigned int irq, struct irq_desc *desc)
&irq_affinity_hint_proc_fops, (void *)(long)irq);
/* create /proc/irq/<irq>/smp_affinity_list */
- proc_create_data("smp_affinity_list", 0600, desc->dir,
+ proc_create_data("smp_affinity_list", 0644, desc->dir,
&irq_affinity_list_proc_fops, (void *)(long)irq);
proc_create_data("node", 0444, desc->dir,
@@ -372,7 +372,7 @@ void unregister_handler_proc(unsigned int irq, struct irqaction *action)
static void register_default_affinity_proc(void)
{
#ifdef CONFIG_SMP
- proc_create("irq/default_smp_affinity", 0600, NULL,
+ proc_create("irq/default_smp_affinity", 0644, NULL,
&default_affinity_proc_fops);
#endif
}
--
1.9.0.279.gdc9e3eb
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] procfs: make smp_affinity values 0644
2014-03-14 2:05 [PATCH] procfs: make smp_affinity values 0644 Chema Gonzalez
@ 2014-03-14 2:37 ` Eric Dumazet
2014-03-14 2:40 ` Chema Gonzalez
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2014-03-14 2:37 UTC (permalink / raw)
To: Chema Gonzalez; +Cc: Thomas Gleixner, Eric Dumazet, linux-kernel
On Thu, 2014-03-13 at 19:05 -0700, Chema Gonzalez wrote:
> Includes:
> - /proc/irq/default_smp_affinity
> - /proc/irq/*/smp_affinity
> - /proc/irq/*/smp_affinity_list
>
> Users can distill the same information by reading /proc/interrupts.
>
> Signed-off-by: Chema Gonzalez <chema@google.com>
> ---
Seems good to me, but what about affinity_hint ?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] procfs: make smp_affinity values 0644
2014-03-14 2:37 ` Eric Dumazet
@ 2014-03-14 2:40 ` Chema Gonzalez
0 siblings, 0 replies; 3+ messages in thread
From: Chema Gonzalez @ 2014-03-14 2:40 UTC (permalink / raw)
To: Eric Dumazet; +Cc: Thomas Gleixner, Eric Dumazet, linux-kernel
0444 maybe?
-Chema
On Thu, Mar 13, 2014 at 7:37 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Thu, 2014-03-13 at 19:05 -0700, Chema Gonzalez wrote:
>> Includes:
>> - /proc/irq/default_smp_affinity
>> - /proc/irq/*/smp_affinity
>> - /proc/irq/*/smp_affinity_list
>>
>> Users can distill the same information by reading /proc/interrupts.
>>
>> Signed-off-by: Chema Gonzalez <chema@google.com>
>> ---
>
> Seems good to me, but what about affinity_hint ?
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-14 2:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-14 2:05 [PATCH] procfs: make smp_affinity values 0644 Chema Gonzalez
2014-03-14 2:37 ` Eric Dumazet
2014-03-14 2:40 ` Chema Gonzalez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®