From: Jiri Olsa <jolsa@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Jiri Olsa <jolsa@redhat.com>, Don Zickus <dzickus@redhat.com>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: [PATCH 5/5] perf tools: Share process map groups within process threads
Date: Fri, 14 Mar 2014 15:00:06 +0100 [thread overview]
Message-ID: <1394805606-25883-6-git-send-email-jolsa@redhat.com> (raw)
In-Reply-To: <1394805606-25883-1-git-send-email-jolsa@redhat.com>
Sharing map groups within all process threads. This way
there's only one copy of mmap info and it's reachale
from any thread within the process.
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
---
tools/perf/util/map.h | 2 ++
tools/perf/util/thread.c | 37 ++++++++++++++++++++++++++++++++++---
2 files changed, 36 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/map.h b/tools/perf/util/map.h
index 99a6488..d4c8df2 100644
--- a/tools/perf/util/map.h
+++ b/tools/perf/util/map.h
@@ -59,6 +59,8 @@ struct map_groups {
struct rb_root maps[MAP__NR_TYPES];
struct list_head removed_maps[MAP__NR_TYPES];
struct machine *machine;
+ /* Used for thread sharing */
+ int refcnt;
};
static inline struct kmap *map__kmap(struct map *map)
diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c
index 7c1aad0..2599754 100644
--- a/tools/perf/util/thread.c
+++ b/tools/perf/util/thread.c
@@ -156,6 +156,16 @@ int thread__fork(struct thread *thread, struct thread *parent, u64 timestamp)
return 0;
}
+static struct thread* thread__get_leader(struct thread *thread)
+{
+ pid_t pid = thread->pid_;
+
+ if (pid == thread->tid)
+ return thread;
+
+ return machine__findnew_thread(thread->machine, pid, pid);
+}
+
static struct map_groups* thread__map_groups_alloc(struct thread *thread)
{
struct map_groups* mg = zalloc(sizeof(*mg));
@@ -172,13 +182,34 @@ struct map_groups* thread__map_groups_get(struct thread *thread)
{
struct map_groups* mg = thread->mg;
- if (!mg)
- mg = thread__map_groups_alloc(thread);
+ if (!mg) {
+ struct thread *leader = thread__get_leader(thread);
+
+ if (!leader)
+ return NULL;
+
+ if (leader->mg)
+ mg = leader->mg;
+ else
+ mg = thread__map_groups_alloc(leader);
+
+ if (leader != thread)
+ thread->mg = mg;
+
+ mg->refcnt++;
+ }
return mg;
}
void thread__map_groups_put(struct thread *thread)
{
- zfree(&thread->mg);
+ struct map_groups* mg = thread->mg;
+
+ if (mg) {
+ BUG_ON(!mg->refcnt);
+
+ if (!--mg->refcnt)
+ zfree(&thread->mg);
+ }
}
--
1.8.3.1
next prev parent reply other threads:[~2014-03-14 14:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 14:00 [RFC 0/5] perf tools: Share map groups within process Jiri Olsa
2014-03-14 14:00 ` [PATCH 1/5] perf tests: Add tip/pid mmap automated tests Jiri Olsa
2014-03-14 20:24 ` Arnaldo Carvalho de Melo
2014-03-17 6:57 ` Jiri Olsa
2014-03-17 4:50 ` Namhyung Kim
2014-03-17 10:39 ` Jiri Olsa
2014-03-14 14:00 ` [PATCH 2/5] perf tools: Factor machine__find_thread to take tid argument Jiri Olsa
2014-03-14 14:15 ` Arnaldo Carvalho de Melo
2014-03-14 15:40 ` Adrian Hunter
2014-03-18 8:31 ` [tip:perf/core] perf machine: " tip-bot for Jiri Olsa
2014-03-14 14:00 ` [PATCH 3/5] perf tools: Allocate thread map_groups dynamicaly Jiri Olsa
2014-03-14 14:13 ` Arnaldo Carvalho de Melo
2014-03-17 7:13 ` Namhyung Kim
2014-03-17 14:52 ` Jiri Olsa
[not found] ` <87lhw8rnsi.fsf@sejong.aot.lge.com>
2014-03-18 13:31 ` Jiri Olsa
2014-03-14 14:00 ` [PATCH 4/5] perf tools: Add machine pointer into thread struct Jiri Olsa
2014-03-14 14:16 ` Arnaldo Carvalho de Melo
2014-03-17 7:17 ` Namhyung Kim
2014-03-17 14:56 ` Jiri Olsa
2014-03-14 14:00 ` Jiri Olsa [this message]
2014-03-14 14:18 ` [PATCH 5/5] perf tools: Share process map groups within process threads Arnaldo Carvalho de Melo
2014-03-17 7:25 ` Namhyung Kim
2014-03-17 10:45 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394805606-25883-6-git-send-email-jolsa@redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=dzickus@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®