From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org, Don Zickus <dzickus@redhat.com>,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Subject: Re: [PATCH 3/5] perf tools: Allocate thread map_groups dynamicaly
Date: Mon, 17 Mar 2014 16:13:53 +0900 [thread overview]
Message-ID: <87d2hlthzi.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <1394805606-25883-4-git-send-email-jolsa@redhat.com> (Jiri Olsa's message of "Fri, 14 Mar 2014 15:00:04 +0100")
On Fri, 14 Mar 2014 15:00:04 +0100, Jiri Olsa wrote:
> Moving towards sharing map groups within a process threads.
>
> Because of this we need the map groups to be dynamically
> allocated. No other functional change is intended in here.
> @@ -664,7 +664,7 @@ void thread__find_addr_map(struct thread *thread,
> al->cpumode = cpumode;
> al->filtered = false;
>
> - if (machine == NULL) {
> + if ((machine == NULL) || (mg == NULL)) {
> al->map = NULL;
> return;
> }
What about the kernel threads? I guess they're not using thread->mg but
machine->kmaps instead?
Thanks,
Namhyung
next prev parent reply other threads:[~2014-03-17 7:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 14:00 [RFC 0/5] perf tools: Share map groups within process Jiri Olsa
2014-03-14 14:00 ` [PATCH 1/5] perf tests: Add tip/pid mmap automated tests Jiri Olsa
2014-03-14 20:24 ` Arnaldo Carvalho de Melo
2014-03-17 6:57 ` Jiri Olsa
2014-03-17 4:50 ` Namhyung Kim
2014-03-17 10:39 ` Jiri Olsa
2014-03-14 14:00 ` [PATCH 2/5] perf tools: Factor machine__find_thread to take tid argument Jiri Olsa
2014-03-14 14:15 ` Arnaldo Carvalho de Melo
2014-03-14 15:40 ` Adrian Hunter
2014-03-18 8:31 ` [tip:perf/core] perf machine: " tip-bot for Jiri Olsa
2014-03-14 14:00 ` [PATCH 3/5] perf tools: Allocate thread map_groups dynamicaly Jiri Olsa
2014-03-14 14:13 ` Arnaldo Carvalho de Melo
2014-03-17 7:13 ` Namhyung Kim [this message]
2014-03-17 14:52 ` Jiri Olsa
[not found] ` <87lhw8rnsi.fsf@sejong.aot.lge.com>
2014-03-18 13:31 ` Jiri Olsa
2014-03-14 14:00 ` [PATCH 4/5] perf tools: Add machine pointer into thread struct Jiri Olsa
2014-03-14 14:16 ` Arnaldo Carvalho de Melo
2014-03-17 7:17 ` Namhyung Kim
2014-03-17 14:56 ` Jiri Olsa
2014-03-14 14:00 ` [PATCH 5/5] perf tools: Share process map groups within process threads Jiri Olsa
2014-03-14 14:18 ` Arnaldo Carvalho de Melo
2014-03-17 7:25 ` Namhyung Kim
2014-03-17 10:45 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2hlthzi.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=dzickus@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome