From: Ramkumar Ramachandra <artagnon@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: David Ahern <dsahern@gmail.com>, Jiri Olsa <jolsa@redhat.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 1/4] perf kmem: introduce --list-cmds for use by scripts
Date: Fri, 14 Mar 2014 23:17:51 -0400 [thread overview]
Message-ID: <1394853474-31019-2-git-send-email-artagnon@gmail.com> (raw)
In-Reply-To: <1394853474-31019-1-git-send-email-artagnon@gmail.com>
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
tools/perf/builtin-kmem.c | 8 +++++---
tools/perf/perf-completion.sh | 4 ++--
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c
index 929462a..bd91de0 100644
--- a/tools/perf/builtin-kmem.c
+++ b/tools/perf/builtin-kmem.c
@@ -756,11 +756,13 @@ int cmd_kmem(int argc, const char **argv, const char *prefix __maybe_unused)
OPT_BOOLEAN(0, "raw-ip", &raw_ip, "show raw ip instead of symbol"),
OPT_END()
};
- const char * const kmem_usage[] = {
- "perf kmem [<options>] {record|stat}",
+ const char *const kmem_subcommands[] = { "record", "stat", NULL };
+ const char *kmem_usage[] = {
+ NULL,
NULL
};
- argc = parse_options(argc, argv, kmem_options, kmem_usage, 0);
+ argc = parse_options_subcommand(argc, argv, kmem_options,
+ kmem_subcommands, kmem_usage, 0);
if (!argc)
usage_with_options(kmem_usage, kmem_options);
diff --git a/tools/perf/perf-completion.sh b/tools/perf/perf-completion.sh
index ae3a576..0ef59dd 100644
--- a/tools/perf/perf-completion.sh
+++ b/tools/perf/perf-completion.sh
@@ -121,8 +121,8 @@ __perf_main ()
elif [[ $prev == "-e" && "${words[1]}" == @(record|stat|top) ]]; then
evts=$($cmd list --raw-dump)
__perfcomp_colon "$evts" "$cur"
- # List subcommands for 'perf kvm'
- elif [[ $prev == "kvm" ]]; then
+ # List subcommands for perf commands
+ elif [[ $prev == @(kvm|kmem) ]]; then
subcmds=$($cmd $prev --list-cmds)
__perfcomp_colon "$subcmds" "$cur"
# List long option names
--
1.9.rc0.1.g9d22d25
next prev parent reply other threads:[~2014-03-15 3:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-15 3:17 [PATCH 0/4] perf: trivial follow-ons to --list-cmds Ramkumar Ramachandra
2014-03-15 3:17 ` Ramkumar Ramachandra [this message]
2014-04-17 9:57 ` [tip:perf/core] perf kmem: Introduce --list-cmds for use by scripts tip-bot for Ramkumar Ramachandra
2014-03-15 3:17 ` [PATCH 2/4] perf mem: introduce " Ramkumar Ramachandra
2014-04-17 9:57 ` [tip:perf/core] perf mem: Introduce " tip-bot for Ramkumar Ramachandra
2014-03-15 3:17 ` [PATCH 3/4] perf lock: introduce " Ramkumar Ramachandra
2014-04-17 9:57 ` [tip:perf/core] perf lock: Introduce " tip-bot for Ramkumar Ramachandra
2014-03-15 3:17 ` [PATCH 4/4] perf sched: introduce " Ramkumar Ramachandra
2014-04-17 9:57 ` [tip:perf/core] perf sched: Introduce " tip-bot for Ramkumar Ramachandra
2014-03-15 15:49 ` [PATCH 0/4] perf: trivial follow-ons to --list-cmds David Ahern
2014-03-27 0:05 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394853474-31019-2-git-send-email-artagnon@gmail.com \
--to=artagnon@gmail.com \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome