From: tip-bot for Ramkumar Ramachandra <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, linux-kernel@vger.kernel.org, hpa@zytor.com,
mingo@kernel.org, jolsa@redhat.com, dsahern@gmail.com,
tglx@linutronix.de, artagnon@gmail.com
Subject: [tip:perf/core] perf mem: Introduce --list-cmds for use by scripts
Date: Thu, 17 Apr 2014 02:57:15 -0700 [thread overview]
Message-ID: <tip-8d2a2a1d885d36e978c4619a3db8791f9768dd6a@git.kernel.org> (raw)
In-Reply-To: <1394853474-31019-3-git-send-email-artagnon@gmail.com>
Commit-ID: 8d2a2a1d885d36e978c4619a3db8791f9768dd6a
Gitweb: http://git.kernel.org/tip/8d2a2a1d885d36e978c4619a3db8791f9768dd6a
Author: Ramkumar Ramachandra <artagnon@gmail.com>
AuthorDate: Fri, 14 Mar 2014 23:17:52 -0400
Committer: Jiri Olsa <jolsa@redhat.com>
CommitDate: Wed, 16 Apr 2014 17:16:04 +0200
perf mem: Introduce --list-cmds for use by scripts
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Acked-by: David Ahern <dsahern@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lkml.kernel.org/r/1394853474-31019-3-git-send-email-artagnon@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
---
tools/perf/builtin-mem.c | 15 ++++++++-------
tools/perf/perf-completion.sh | 2 +-
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/tools/perf/builtin-mem.c b/tools/perf/builtin-mem.c
index 2e3ade69..4a1a6c9 100644
--- a/tools/perf/builtin-mem.c
+++ b/tools/perf/builtin-mem.c
@@ -21,11 +21,6 @@ struct perf_mem {
DECLARE_BITMAP(cpu_bitmap, MAX_NR_CPUS);
};
-static const char * const mem_usage[] = {
- "perf mem [<options>] {record <command> |report}",
- NULL
-};
-
static int __cmd_record(int argc, const char **argv)
{
int rec_argc, i = 0, j;
@@ -220,9 +215,15 @@ int cmd_mem(int argc, const char **argv, const char *prefix __maybe_unused)
" between columns '.' is reserved."),
OPT_END()
};
+ const char *const mem_subcommands[] = { "record", "report", NULL };
+ const char *mem_usage[] = {
+ NULL,
+ NULL
+ };
+
- argc = parse_options(argc, argv, mem_options, mem_usage,
- PARSE_OPT_STOP_AT_NON_OPTION);
+ argc = parse_options_subcommand(argc, argv, mem_options, mem_subcommands,
+ mem_usage, PARSE_OPT_STOP_AT_NON_OPTION);
if (!argc || !(strncmp(argv[0], "rec", 3) || mem_operation))
usage_with_options(mem_usage, mem_options);
diff --git a/tools/perf/perf-completion.sh b/tools/perf/perf-completion.sh
index 0ef59dd..f44c04b 100644
--- a/tools/perf/perf-completion.sh
+++ b/tools/perf/perf-completion.sh
@@ -122,7 +122,7 @@ __perf_main ()
evts=$($cmd list --raw-dump)
__perfcomp_colon "$evts" "$cur"
# List subcommands for perf commands
- elif [[ $prev == @(kvm|kmem) ]]; then
+ elif [[ $prev == @(kvm|kmem|mem) ]]; then
subcmds=$($cmd $prev --list-cmds)
__perfcomp_colon "$subcmds" "$cur"
# List long option names
next prev parent reply other threads:[~2014-04-17 9:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-15 3:17 [PATCH 0/4] perf: trivial follow-ons to --list-cmds Ramkumar Ramachandra
2014-03-15 3:17 ` [PATCH 1/4] perf kmem: introduce --list-cmds for use by scripts Ramkumar Ramachandra
2014-04-17 9:57 ` [tip:perf/core] perf kmem: Introduce " tip-bot for Ramkumar Ramachandra
2014-03-15 3:17 ` [PATCH 2/4] perf mem: introduce " Ramkumar Ramachandra
2014-04-17 9:57 ` tip-bot for Ramkumar Ramachandra [this message]
2014-03-15 3:17 ` [PATCH 3/4] perf lock: " Ramkumar Ramachandra
2014-04-17 9:57 ` [tip:perf/core] perf lock: Introduce " tip-bot for Ramkumar Ramachandra
2014-03-15 3:17 ` [PATCH 4/4] perf sched: introduce " Ramkumar Ramachandra
2014-04-17 9:57 ` [tip:perf/core] perf sched: Introduce " tip-bot for Ramkumar Ramachandra
2014-03-15 15:49 ` [PATCH 0/4] perf: trivial follow-ons to --list-cmds David Ahern
2014-03-27 0:05 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-8d2a2a1d885d36e978c4619a3db8791f9768dd6a@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=artagnon@gmail.com \
--cc=dsahern@gmail.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome