From: Vivek Goyal <vgoyal@redhat.com>
To: linux-kernel@vger.kernel.org, hpa@zytor.com
Cc: Vivek Goyal <vgoyal@redhat.com>
Subject: [PATCH 0/5] x86/boot: Some string function cleanup and consolidation
Date: Tue, 18 Mar 2014 15:26:35 -0400 [thread overview]
Message-ID: <1395170800-11059-1-git-send-email-vgoyal@redhat.com> (raw)
Hi Peter,
I have tried cleaning up a bit the usage of string functions in arch/x86/boot/.
I have created x86/boot/string.h which all the callers can include and by
default they get the built in definition of memcpy, memset and memcmp. Those
who want to use optimized version of these functions, need to #undef respective
macro and link again the approprate string.c file which provides the function
definition.
After this change I am planning to include x86/boot/string.h in purgatory
code and get built-in definitions of memcpy, memset and memcmp.
There seem to be lot of magic going on in arch/x86/boot/. I do not claim
to understand it all. Hopefully above changes do not break anything.
Please have a look.
Thanks
Vivek
Vivek Goyal (5):
x86/boot: undef memcmp before providing a new definition
x86/boot: Create a separate string.h file to provide standard string
functions
x86/boot: Move optmized memcpy() 32/64 bit versions to
compressed/string.c
x86/boot: Move memcmp() into string.h and string.c
x86/boot: Move memset() definition in compressed/string.c
arch/x86/boot/boot.h | 13 ----------
arch/x86/boot/compressed/misc.c | 51 ++++++---------------------------------
arch/x86/boot/compressed/string.c | 46 ++++++++++++++++++++++++++++++-----
arch/x86/boot/cpucheck.c | 1 +
arch/x86/boot/edd.c | 1 +
arch/x86/boot/main.c | 1 +
arch/x86/boot/regs.c | 1 +
arch/x86/boot/string.c | 14 +++++++++++
arch/x86/boot/string.h | 21 ++++++++++++++++
arch/x86/boot/video-vesa.c | 1 +
10 files changed, 88 insertions(+), 62 deletions(-)
create mode 100644 arch/x86/boot/string.h
--
1.8.5.3
next reply other threads:[~2014-03-18 19:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 19:26 Vivek Goyal [this message]
2014-03-18 19:26 ` [PATCH 1/5] x86/boot: undef memcmp before providing a new definition Vivek Goyal
2014-03-19 23:30 ` [tip:x86/boot] x86, boot: Undef " tip-bot for Vivek Goyal
2014-03-18 19:26 ` [PATCH 2/5] x86/boot: Create a separate string.h file to provide standard string functions Vivek Goyal
2014-03-19 23:30 ` [tip:x86/boot] x86, boot: " tip-bot for Vivek Goyal
2014-03-18 19:26 ` [PATCH 3/5] x86/boot: Move optmized memcpy() 32/64 bit versions to compressed/string.c Vivek Goyal
2014-03-19 23:31 ` [tip:x86/boot] x86, boot: Move optimized memcpy() 32/ 64 " tip-bot for Vivek Goyal
2014-03-18 19:26 ` [PATCH 4/5] x86/boot: Move memcmp() into string.h and string.c Vivek Goyal
2014-03-19 23:31 ` [tip:x86/boot] x86, boot: " tip-bot for Vivek Goyal
2014-03-18 19:26 ` [PATCH 5/5] x86/boot: Move memset() definition in compressed/string.c Vivek Goyal
2014-03-19 23:31 ` [tip:x86/boot] x86, boot: Move memset() definition in compressed/ string.c tip-bot for Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395170800-11059-1-git-send-email-vgoyal@redhat.com \
--to=vgoyal@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome