From: tip-bot for Vivek Goyal <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org,
tglx@linutronix.de, hpa@linux.intel.com, vgoyal@redhat.com
Subject: [tip:x86/boot] x86, boot: Undef memcmp before providing a new definition
Date: Wed, 19 Mar 2014 16:30:45 -0700 [thread overview]
Message-ID: <tip-aad830938ed8ba175d8060751654f78d4115ea0a@git.kernel.org> (raw)
In-Reply-To: <1395170800-11059-2-git-send-email-vgoyal@redhat.com>
Commit-ID: aad830938ed8ba175d8060751654f78d4115ea0a
Gitweb: http://git.kernel.org/tip/aad830938ed8ba175d8060751654f78d4115ea0a
Author: Vivek Goyal <vgoyal@redhat.com>
AuthorDate: Tue, 18 Mar 2014 15:26:36 -0400
Committer: H. Peter Anvin <hpa@linux.intel.com>
CommitDate: Wed, 19 Mar 2014 15:43:37 -0700
x86, boot: Undef memcmp before providing a new definition
With CONFIG_X86_32=y, string_32.h gets pulled in compressed/string.c by
"misch.h". string_32.h defines a macro to map memcmp to __builtin_memcmp().
And that macro in turn changes the name of memcmp() defined here and
converts it to __builtin_memcmp().
I thought that's not the intention though. We probably want to provide
our own optimized definition of memcmp(). If yes, then undef the memcmp
before we define a new memcmp.
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Link: http://lkml.kernel.org/r/1395170800-11059-2-git-send-email-vgoyal@redhat.com
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
---
arch/x86/boot/compressed/string.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/boot/compressed/string.c b/arch/x86/boot/compressed/string.c
index ffb9c5c..212004e 100644
--- a/arch/x86/boot/compressed/string.c
+++ b/arch/x86/boot/compressed/string.c
@@ -1,5 +1,7 @@
#include "misc.h"
+/* Avoid intereference from any defines in string_32.h */
+#undef memcmp
int memcmp(const void *s1, const void *s2, size_t len)
{
u8 diff;
next prev parent reply other threads:[~2014-03-19 23:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 19:26 [PATCH 0/5] x86/boot: Some string function cleanup and consolidation Vivek Goyal
2014-03-18 19:26 ` [PATCH 1/5] x86/boot: undef memcmp before providing a new definition Vivek Goyal
2014-03-19 23:30 ` tip-bot for Vivek Goyal [this message]
2014-03-18 19:26 ` [PATCH 2/5] x86/boot: Create a separate string.h file to provide standard string functions Vivek Goyal
2014-03-19 23:30 ` [tip:x86/boot] x86, boot: " tip-bot for Vivek Goyal
2014-03-18 19:26 ` [PATCH 3/5] x86/boot: Move optmized memcpy() 32/64 bit versions to compressed/string.c Vivek Goyal
2014-03-19 23:31 ` [tip:x86/boot] x86, boot: Move optimized memcpy() 32/ 64 " tip-bot for Vivek Goyal
2014-03-18 19:26 ` [PATCH 4/5] x86/boot: Move memcmp() into string.h and string.c Vivek Goyal
2014-03-19 23:31 ` [tip:x86/boot] x86, boot: " tip-bot for Vivek Goyal
2014-03-18 19:26 ` [PATCH 5/5] x86/boot: Move memset() definition in compressed/string.c Vivek Goyal
2014-03-19 23:31 ` [tip:x86/boot] x86, boot: Move memset() definition in compressed/ string.c tip-bot for Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-aad830938ed8ba175d8060751654f78d4115ea0a@git.kernel.org \
--to=tipbot@zytor.com \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome