mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	Namhyung Kim <namhyung@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
	David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Andi Kleen <andi@firstfloor.org>, Arun Sharma <asharma@fb.com>,
	Rodrigo Campos <rodrigo@sdfg.com.ar>
Subject: [PATCH 10/21] perf ui/browser: Add support to accumulated hist stat
Date: Thu, 20 Mar 2014 14:36:35 +0900	[thread overview]
Message-ID: <1395293806-25847-11-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1395293806-25847-1-git-send-email-namhyung@kernel.org>

Print accumulated stat of a hist entry if requested.

Tested-by: Arun Sharma <asharma@fb.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/ui/browsers/hists.c | 26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)

diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index 3d028c85fb53..5089bc1f2259 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -603,7 +603,6 @@ static int __hpp__slsmg_color_printf(struct perf_hpp *hpp, const char *fmt, ...)
 	ret = scnprintf(hpp->buf, hpp->size, fmt, percent);
 	slsmg_printf("%s", hpp->buf);
 
-	advance_hpp(hpp, ret);
 	return ret;
 }
 
@@ -622,13 +621,36 @@ hist_browser__hpp_color_##_type(struct perf_hpp_fmt *fmt __maybe_unused,\
 			  __hpp__slsmg_color_printf, true);		\
 }
 
+#define __HPP_COLOR_ACC_PERCENT_FN(_type, _field)			\
+static u64 __hpp_get_acc_##_field(struct hist_entry *he)		\
+{									\
+	return he->stat_acc->_field;					\
+}									\
+									\
+static int								\
+hist_browser__hpp_color_##_type(struct perf_hpp_fmt *fmt __maybe_unused,\
+				struct perf_hpp *hpp,			\
+				struct hist_entry *he)			\
+{									\
+	if (!symbol_conf.cumulate_callchain) {				\
+		int ret = scnprintf(hpp->buf, hpp->size, "%8s", "N/A");	\
+		slsmg_printf("%s", hpp->buf);				\
+									\
+		return ret;						\
+	}								\
+	return __hpp__fmt(hpp, he, __hpp_get_acc_##_field, " %6.2f%%",	\
+			  __hpp__slsmg_color_printf, true);		\
+}
+
 __HPP_COLOR_PERCENT_FN(overhead, period)
 __HPP_COLOR_PERCENT_FN(overhead_sys, period_sys)
 __HPP_COLOR_PERCENT_FN(overhead_us, period_us)
 __HPP_COLOR_PERCENT_FN(overhead_guest_sys, period_guest_sys)
 __HPP_COLOR_PERCENT_FN(overhead_guest_us, period_guest_us)
+__HPP_COLOR_ACC_PERCENT_FN(overhead_acc, period)
 
 #undef __HPP_COLOR_PERCENT_FN
+#undef __HPP_COLOR_ACC_PERCENT_FN
 
 void hist_browser__init_hpp(void)
 {
@@ -644,6 +666,8 @@ void hist_browser__init_hpp(void)
 				hist_browser__hpp_color_overhead_guest_sys;
 	perf_hpp__format[PERF_HPP__OVERHEAD_GUEST_US].color =
 				hist_browser__hpp_color_overhead_guest_us;
+	perf_hpp__format[PERF_HPP__OVERHEAD_ACC].color =
+				hist_browser__hpp_color_overhead_acc;
 }
 
 static int hist_browser__show_entry(struct hist_browser *browser,
-- 
1.7.11.7


  parent reply	other threads:[~2014-03-20  5:41 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-20  5:36 [PATCHSET 00/21] perf tools: Add support to accumulate hist periods (v9) Namhyung Kim
2014-03-20  5:36 ` [PATCH 01/21] perf tools: Introduce struct hist_entry_iter Namhyung Kim
2014-03-20  5:36 ` [PATCH 02/21] perf hists: Add support for accumulated stat of hist entry Namhyung Kim
2014-03-20  5:36 ` [PATCH 03/21] perf hists: Check if accumulated when adding a " Namhyung Kim
2014-03-20  5:36 ` [PATCH 04/21] perf hists: Accumulate hist entry stat based on the callchain Namhyung Kim
2014-03-20  5:36 ` [PATCH 05/21] perf tools: Update cpumode for each cumulative entry Namhyung Kim
2014-03-20  5:36 ` [PATCH 06/21] perf report: Cache cumulative callchains Namhyung Kim
2014-03-20  5:36 ` [PATCH 07/21] perf callchain: Add callchain_cursor_snapshot() Namhyung Kim
2014-03-20  5:36 ` [PATCH 08/21] perf tools: Save callchain info for each cumulative entry Namhyung Kim
2014-03-20  5:36 ` [PATCH 09/21] perf ui/hist: Add support to accumulated hist stat Namhyung Kim
2014-03-20  5:36 ` Namhyung Kim [this message]
2014-03-20  5:36 ` [PATCH 11/21] perf ui/gtk: " Namhyung Kim
2014-03-20  5:36 ` [PATCH 12/21] perf tools: Apply percent-limit to cumulative percentage Namhyung Kim
2014-03-20  5:36 ` [PATCH 13/21] perf tools: Add more hpp helper functions Namhyung Kim
2014-03-20  5:36 ` [PATCH 14/21] perf report: Add --children option Namhyung Kim
2014-03-20  5:36 ` [PATCH 15/21] perf report: Add report.children config option Namhyung Kim
2014-03-20  5:36 ` [PATCH 16/21] perf tools: Do not auto-remove Children column if --fields given Namhyung Kim
2014-03-20  5:36 ` [PATCH 17/21] perf tools: Add callback function to hist_entry_iter Namhyung Kim
2014-03-20  5:36 ` [PATCH 18/21] perf top: Convert " Namhyung Kim
2014-03-20  5:36 ` [PATCH 19/21] perf top: Add --children option Namhyung Kim
2014-03-20  5:36 ` [PATCH 20/21] perf top: Add top.children config option Namhyung Kim
2014-03-20  5:36 ` [PATCH 21/21] perf tools: Enable --children option by default Namhyung Kim
2014-03-31 14:26 ` [PATCHSET 00/21] perf tools: Add support to accumulate hist periods (v9) Arun Sharma
2014-04-01  7:28   ` Namhyung Kim
2014-04-01  7:35     ` Arun Sharma
2014-05-19 15:11 ` Rodrigo Campos
2014-05-20  2:29   ` Namhyung Kim
2014-05-20  3:06     ` Rodrigo Campos
2014-05-20  7:35       ` Jiri Olsa
2014-05-20 12:00         ` Rodrigo Campos
2014-05-20 14:01           ` Jiri Olsa
2014-05-20 15:52             ` Rodrigo Campos
  -- strict thread matches above, loose matches on Subject: below --
2013-12-24  8:22 [PATCHSET 00/21] perf tools: Add support to accumulate hist periods (v4) Namhyung Kim
2013-12-24  8:22 ` [PATCH 10/21] perf ui/browser: Add support to accumulated hist stat Namhyung Kim
2014-01-05 17:33   ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395293806-25847-11-git-send-email-namhyung@kernel.org \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=andi@firstfloor.org \
    --cc=asharma@fb.com \
    --cc=dsahern@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    --cc=rodrigo@sdfg.com.ar \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®