From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
Namhyung Kim <namhyung@kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Andi Kleen <andi@firstfloor.org>, Arun Sharma <asharma@fb.com>,
Rodrigo Campos <rodrigo@sdfg.com.ar>
Subject: [PATCH 08/21] perf tools: Save callchain info for each cumulative entry
Date: Thu, 20 Mar 2014 14:36:33 +0900 [thread overview]
Message-ID: <1395293806-25847-9-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1395293806-25847-1-git-send-email-namhyung@kernel.org>
When accumulating callchain entry, also save current snapshot of the
chain so that it can show the rest of the chain.
Tested-by: Arun Sharma <asharma@fb.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/hist.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
index c393f13789cb..898cf0155c60 100644
--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -752,6 +752,14 @@ iter_add_single_cumulative_entry(struct hist_entry_iter *iter,
he_cache[iter->curr++] = he;
+ callchain_append(he->callchain, &callchain_cursor, sample->period);
+
+ /*
+ * We need to re-initialize the cursor since callchain_append()
+ * advanced the cursor to the end.
+ */
+ callchain_cursor_commit(&callchain_cursor);
+
return hist_entry__inc_addr_samples(he, evsel->idx, al->addr);
}
@@ -765,8 +773,6 @@ iter_next_cumulative_entry(struct hist_entry_iter *iter,
if (node == NULL)
return 0;
- callchain_cursor_advance(&callchain_cursor);
-
return fill_callchain_info(al, node, iter->hide_unresolved);
}
@@ -790,6 +796,11 @@ iter_add_next_cumulative_entry(struct hist_entry_iter *iter,
.parent = iter->parent,
};
int i;
+ struct callchain_cursor cursor;
+
+ callchain_cursor_snapshot(&cursor, &callchain_cursor);
+
+ callchain_cursor_advance(&callchain_cursor);
/*
* Check if there's duplicate entries in the callchain.
@@ -808,6 +819,8 @@ iter_add_next_cumulative_entry(struct hist_entry_iter *iter,
he_cache[iter->curr++] = he;
+ callchain_append(he->callchain, &cursor, sample->period);
+
return hist_entry__inc_addr_samples(he, evsel->idx, al->addr);
}
--
1.7.11.7
next prev parent reply other threads:[~2014-03-20 5:41 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 5:36 [PATCHSET 00/21] perf tools: Add support to accumulate hist periods (v9) Namhyung Kim
2014-03-20 5:36 ` [PATCH 01/21] perf tools: Introduce struct hist_entry_iter Namhyung Kim
2014-03-20 5:36 ` [PATCH 02/21] perf hists: Add support for accumulated stat of hist entry Namhyung Kim
2014-03-20 5:36 ` [PATCH 03/21] perf hists: Check if accumulated when adding a " Namhyung Kim
2014-03-20 5:36 ` [PATCH 04/21] perf hists: Accumulate hist entry stat based on the callchain Namhyung Kim
2014-03-20 5:36 ` [PATCH 05/21] perf tools: Update cpumode for each cumulative entry Namhyung Kim
2014-03-20 5:36 ` [PATCH 06/21] perf report: Cache cumulative callchains Namhyung Kim
2014-03-20 5:36 ` [PATCH 07/21] perf callchain: Add callchain_cursor_snapshot() Namhyung Kim
2014-03-20 5:36 ` Namhyung Kim [this message]
2014-03-20 5:36 ` [PATCH 09/21] perf ui/hist: Add support to accumulated hist stat Namhyung Kim
2014-03-20 5:36 ` [PATCH 10/21] perf ui/browser: " Namhyung Kim
2014-03-20 5:36 ` [PATCH 11/21] perf ui/gtk: " Namhyung Kim
2014-03-20 5:36 ` [PATCH 12/21] perf tools: Apply percent-limit to cumulative percentage Namhyung Kim
2014-03-20 5:36 ` [PATCH 13/21] perf tools: Add more hpp helper functions Namhyung Kim
2014-03-20 5:36 ` [PATCH 14/21] perf report: Add --children option Namhyung Kim
2014-03-20 5:36 ` [PATCH 15/21] perf report: Add report.children config option Namhyung Kim
2014-03-20 5:36 ` [PATCH 16/21] perf tools: Do not auto-remove Children column if --fields given Namhyung Kim
2014-03-20 5:36 ` [PATCH 17/21] perf tools: Add callback function to hist_entry_iter Namhyung Kim
2014-03-20 5:36 ` [PATCH 18/21] perf top: Convert " Namhyung Kim
2014-03-20 5:36 ` [PATCH 19/21] perf top: Add --children option Namhyung Kim
2014-03-20 5:36 ` [PATCH 20/21] perf top: Add top.children config option Namhyung Kim
2014-03-20 5:36 ` [PATCH 21/21] perf tools: Enable --children option by default Namhyung Kim
2014-03-31 14:26 ` [PATCHSET 00/21] perf tools: Add support to accumulate hist periods (v9) Arun Sharma
2014-04-01 7:28 ` Namhyung Kim
2014-04-01 7:35 ` Arun Sharma
2014-05-19 15:11 ` Rodrigo Campos
2014-05-20 2:29 ` Namhyung Kim
2014-05-20 3:06 ` Rodrigo Campos
2014-05-20 7:35 ` Jiri Olsa
2014-05-20 12:00 ` Rodrigo Campos
2014-05-20 14:01 ` Jiri Olsa
2014-05-20 15:52 ` Rodrigo Campos
-- strict thread matches above, loose matches on Subject: below --
2014-02-07 1:35 [PATCHSET 00/21] perf tools: Add support to accumulate hist periods (v8) Namhyung Kim
2014-02-07 1:35 ` [PATCH 08/21] perf tools: Save callchain info for each cumulative entry Namhyung Kim
2014-01-23 0:13 [PATCHSET 00/24] perf tools: Add support to accumulate hist periods (v7) Namhyung Kim
2014-01-23 0:13 ` [PATCH 08/21] perf tools: Save callchain info for each cumulative entry Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395293806-25847-9-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=andi@firstfloor.org \
--cc=asharma@fb.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
--cc=rodrigo@sdfg.com.ar \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®