mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] block: Use RCU_INIT_POINTER(x, NULL) in genhd.c
@ 2014-03-22 20:30 Monam Agarwal
  0 siblings, 0 replies; only message in thread
From: Monam Agarwal @ 2014-03-22 20:30 UTC (permalink / raw)
  To: axboe, linux-kernel

This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

The rcu_assign_pointer() ensures that the initialization of a structure       
is carried out before storing a pointer to that structure. 
And in the case of the NULL pointer, there is no structure to initialize. 
So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
---
 block/genhd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/genhd.c b/block/genhd.c
index 791f419..3aec057 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -1045,7 +1045,7 @@ static void disk_replace_part_tbl(struct gendisk *disk,
 	rcu_assign_pointer(disk->part_tbl, new_ptbl);
 
 	if (old_ptbl) {
-		rcu_assign_pointer(old_ptbl->last_lookup, NULL);
+		RCU_INIT_POINTER(old_ptbl->last_lookup, NULL);
 		kfree_rcu(old_ptbl, rcu_head);
 	}
 }
-- 
1.7.9.5


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2014-03-22 20:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-22 20:30 [PATCH] block: Use RCU_INIT_POINTER(x, NULL) in genhd.c Monam Agarwal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®