* [PATCH] kernel: Use RCU_INIT_POINTER(x, NULL) in cgroup.c
@ 2014-03-23 18:47 Monam Agarwal
2014-03-24 12:49 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Monam Agarwal @ 2014-03-23 18:47 UTC (permalink / raw)
To: tj, lizefan, containers, cgroups, linux-kernel
This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)
The rcu_assign_pointer() ensures that the initialization of a structure
is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to initialize.
So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
---
kernel/cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 105f273..3462f62 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -4033,7 +4033,7 @@ static void css_release(struct percpu_ref *ref)
struct cgroup_subsys_state *css =
container_of(ref, struct cgroup_subsys_state, refcnt);
- rcu_assign_pointer(css->cgroup->subsys[css->ss->subsys_id], NULL);
+ RCU_INIT_POINTER(css->cgroup->subsys[css->ss->subsys_id], NULL);
call_rcu(&css->rcu_head, css_free_rcu_fn);
}
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] kernel: Use RCU_INIT_POINTER(x, NULL) in cgroup.c
2014-03-23 18:47 [PATCH] kernel: Use RCU_INIT_POINTER(x, NULL) in cgroup.c Monam Agarwal
@ 2014-03-24 12:49 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2014-03-24 12:49 UTC (permalink / raw)
To: Monam Agarwal; +Cc: lizefan, containers, cgroups, linux-kernel
On Mon, Mar 24, 2014 at 12:17:18AM +0530, Monam Agarwal wrote:
> This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)
>
> The rcu_assign_pointer() ensures that the initialization of a structure
> is carried out before storing a pointer to that structure.
> And in the case of the NULL pointer, there is no structure to initialize.
> So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)
>
> Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Applied to cgroup/for-3.15.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-24 12:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-23 18:47 [PATCH] kernel: Use RCU_INIT_POINTER(x, NULL) in cgroup.c Monam Agarwal
2014-03-24 12:49 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®