From: Don Zickus <dzickus@redhat.com>
To: acme@ghostprotocols.net
Cc: LKML <linux-kernel@vger.kernel.org>,
jolsa@redhat.com, jmario@redhat.com, fowles@inreach.com,
peterz@infradead.org, eranian@google.com, andi.kleen@intel.com,
Don Zickus <dzickus@redhat.com>
Subject: [PATCH 14/15 V3] perf, c2c: Add symbol count table
Date: Mon, 24 Mar 2014 15:37:05 -0400 [thread overview]
Message-ID: <1395689826-215033-15-git-send-email-dzickus@redhat.com> (raw)
In-Reply-To: <1395689826-215033-1-git-send-email-dzickus@redhat.com>
Just another table that displays the referenced symbols in the analysis
report. The table lists the most frequently used symbols first.
It is just another way to look at similar data to figure out who
is causing the most contention (based on the workload used).
Original done by Dick Fowles, backported by me.
Sample output:
=======================================================================================================
Object Name, Path & Reference Counts
Index Records Object Name Object Path
=======================================================================================================
0 931379 [kernel.kallsyms] [kernel.kallsyms]
1 192258 fio /home/joe/old_fio-2.0.15/fio
2 80302 [jbd2] /lib/modules/3.10.0c2c_all+/kernel/fs/jbd2/jbd2.ko
3 65392 [ext4] /lib/modules/3.10.0c2c_all+/kernel/fs/ext4/ext4.ko
V2: refresh to latest upstream changes and hist_entry
Original-by: Dick Fowles <rfowles@redhat.com>
Signed-off-by: Don Zickus <dzickus@redhat.com>
---
tools/perf/builtin-c2c.c | 99 ++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 99 insertions(+)
diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index a937c4b..e30ce2f 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -688,6 +688,104 @@ static void c2c_hit__update_stats(struct c2c_stats *new,
new->total_period += old->total_period;
}
+LIST_HEAD(ref_tree);
+LIST_HEAD(ref_tree_sorted);
+struct refs {
+ struct list_head list;
+ int nr;
+ const char *name;
+ const char *long_name;
+};
+
+static int update_ref_list(struct hist_entry *entry)
+{
+ struct refs *p;
+ struct dso *dso = entry->mem_info->iaddr.map->dso;
+ const char *name = dso->short_name;
+
+ list_for_each_entry(p, &ref_tree, list) {
+ if (!strcmp(p->name, name))
+ goto found;
+ }
+
+ p = zalloc(sizeof(struct refs));
+ if (!p)
+ return -1;
+ p->name = name;
+ p->long_name = dso->long_name;
+ list_add_tail(&p->list, &ref_tree);
+
+found:
+ p->nr++;
+ return 0;
+}
+
+static void print_symbol_record_count(struct rb_root *tree)
+{
+ struct rb_node *next = rb_first(tree);
+ struct hist_entry *he;
+ struct refs *p, *q, *pn;
+ char string[256];
+ char delimit[256];
+ int i;
+ int idx = 0;
+
+ /* gather symbol references */
+ while (next) {
+ he = rb_entry(next, struct hist_entry, rb_node_in);
+ next = rb_next(&he->rb_node_in);
+
+ if (update_ref_list(he)) {
+ pr_err("Could not update reference tree\n");
+ goto cleanup;
+ }
+ }
+
+ /* sort on number of references per symbol */
+ list_for_each_entry_safe(p, pn, &ref_tree, list) {
+ list_del_init(&p->list);
+ list_for_each_entry(q, &ref_tree_sorted, list) {
+ if (p->nr > q->nr) {
+ list_add_tail(&p->list, &q->list);
+ break;
+ }
+ }
+ if (list_empty(&p->list))
+ list_add_tail(&p->list, &ref_tree_sorted);
+ }
+
+ /* print header info */
+ sprintf(string, "%5s %8s %-32s %-80s",
+ "Index",
+ "Records",
+ "Object Name",
+ "Object Path");
+
+ delimit[0] = '\0';
+ for (i = 0; i < (int)strlen(string); i++) strcat(delimit, "=");
+
+ printf("\n\n");
+ printf("%s\n", delimit);
+ printf("%50s %s\n", " ", "Object Name, Path & Reference Counts");
+ printf("\n");
+ printf("%s\n", string);
+ printf("%s\n", delimit);
+
+ /* print out table */
+ list_for_each_entry(p, &ref_tree_sorted, list) {
+ printf("%5d %8d %-32s %-80s\n",
+ idx, p->nr, p->name, p->long_name);
+ idx++;
+ }
+ printf("\n");
+
+cleanup:
+ list_for_each_entry_safe(p, pn, &ref_tree_sorted, list) {
+ list_del(&p->list);
+ free(p);
+ }
+}
+
static void print_hitm_cacheline_header(void)
{
#define SHARING_REPORT_TITLE "Shared Cache Line Distribution Pareto"
@@ -1269,6 +1367,7 @@ static int perf_c2c__process_events(struct perf_session *session,
dump_rb_tree(c2c->hists.entries_in, c2c);
print_c2c_trace_report(c2c);
c2c_analyze_hitms(c2c);
+ print_symbol_record_count(c2c->hists.entries_in);
err:
return err;
--
1.7.11.7
next prev parent reply other threads:[~2014-03-24 19:40 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 19:36 [PATCH 00/15 V3] perf, c2c: Add new tool to analyze cacheline contention on NUMA systems Don Zickus
2014-03-24 19:36 ` [PATCH 01/15 V3] perf: Fix stddev calculation Don Zickus
2014-03-24 19:36 ` [PATCH 02/15 V3] perf, callchain: Add generic callchain print handler for stdio Don Zickus
2014-03-24 19:36 ` [PATCH 03/15 V3] perf c2c: Shared data analyser Don Zickus
2014-04-08 6:59 ` Namhyung Kim
2014-04-08 14:22 ` Don Zickus
2014-04-09 0:58 ` Namhyung Kim
2014-04-09 1:29 ` Andi Kleen
2014-04-08 14:23 ` Don Zickus
2014-03-24 19:36 ` [PATCH 04/15 V3] perf c2c: Dump raw records, decode data_src bits Don Zickus
2014-04-08 7:09 ` Namhyung Kim
2014-03-24 19:36 ` [PATCH 05/15 V3] perf, c2c: Rework setup code to prepare for features Don Zickus
2014-03-29 17:10 ` Jiri Olsa
2014-04-01 2:52 ` Don Zickus
2014-04-08 7:41 ` Namhyung Kim
2014-04-08 14:11 ` Don Zickus
2014-04-09 1:12 ` Namhyung Kim
2014-04-09 1:36 ` Don Zickus
2014-04-11 14:57 ` Jiri Olsa
2014-04-08 7:18 ` Namhyung Kim
2014-03-24 19:36 ` [PATCH 06/15 V3] perf, c2c: Add in new options to configure latency and stores Don Zickus
2014-03-29 17:11 ` Jiri Olsa
2014-04-01 2:55 ` Don Zickus
2014-04-06 13:14 ` Jiri Olsa
2014-04-07 18:16 ` Don Zickus
2014-04-09 0:17 ` Namhyung Kim
2014-04-08 7:37 ` Namhyung Kim
2014-04-08 7:31 ` Namhyung Kim
2014-03-24 19:36 ` [PATCH 07/15 V3] perf, c2c: Add in sort on physid Don Zickus
2014-04-08 7:56 ` Namhyung Kim
2014-04-08 14:17 ` Don Zickus
2014-04-09 1:30 ` Namhyung Kim
2014-04-09 1:56 ` Don Zickus
2014-03-24 19:36 ` [PATCH 08/15 V3] perf, c2c: Add stats to track data source bits and cpu to node maps Don Zickus
2014-04-08 8:05 ` Namhyung Kim
2014-03-24 19:37 ` [PATCH 09/15 V3] perf, c2c: Sort based on hottest cache line Don Zickus
2014-04-08 8:23 ` Namhyung Kim
2014-03-24 19:37 ` [PATCH 10/15 V3] perf, c2c: Display cacheline HITM analysis to stdout Don Zickus
2014-04-08 8:26 ` Namhyung Kim
2014-04-08 23:46 ` Namhyung Kim
2014-03-24 19:37 ` [PATCH 11/15 V3] perf, c2c: Add callchain support Don Zickus
2014-03-24 19:37 ` [PATCH 12/15 V3] perf, c2c: Output summary stats Don Zickus
2014-03-24 19:37 ` [PATCH 13/15 V3] perf, c2c: Dump rbtree for debugging Don Zickus
2014-03-24 19:37 ` Don Zickus [this message]
2014-03-24 19:37 ` [PATCH 15/15 V3] perf, c2c: Add shared cachline summary table Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395689826-215033-15-git-send-email-dzickus@redhat.com \
--to=dzickus@redhat.com \
--cc=acme@ghostprotocols.net \
--cc=andi.kleen@intel.com \
--cc=eranian@google.com \
--cc=fowles@inreach.com \
--cc=jmario@redhat.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®