From: Don Zickus <dzickus@redhat.com>
To: acme@ghostprotocols.net
Cc: LKML <linux-kernel@vger.kernel.org>,
jolsa@redhat.com, jmario@redhat.com, fowles@inreach.com,
peterz@infradead.org, eranian@google.com, andi.kleen@intel.com,
Don Zickus <dzickus@redhat.com>
Subject: [PATCH 07/15 V3] perf, c2c: Add in sort on physid
Date: Mon, 24 Mar 2014 15:36:58 -0400 [thread overview]
Message-ID: <1395689826-215033-8-git-send-email-dzickus@redhat.com> (raw)
In-Reply-To: <1395689826-215033-1-git-send-email-dzickus@redhat.com>
Now that the infrastructure is set, add in the support to use
hist_entry to sort on physid.
V2: use new mmap2 sort
Signed-off-by: Don Zickus <dzickus@redhat.com>
---
tools/perf/builtin-c2c.c | 52 +++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 51 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
index d7eaf81..b5742bd 100644
--- a/tools/perf/builtin-c2c.c
+++ b/tools/perf/builtin-c2c.c
@@ -7,6 +7,7 @@
#include "util/tool.h"
#include "util/debug.h"
#include <api/fs/fs.h>
+#include "util/annotate.h"
#include <linux/compiler.h>
#include <linux/kernel.h>
@@ -14,6 +15,7 @@
struct perf_c2c {
struct perf_tool tool;
bool raw_records;
+ struct hists hists;
};
enum { OP, LVL, SNP, LCK, TLB };
@@ -151,7 +153,11 @@ static int perf_c2c__process_load_store(struct perf_c2c *c2c,
struct perf_sample *sample,
struct perf_evsel *evsel)
{
+ struct symbol *parent = NULL;
+ struct hist_entry *he;
struct mem_info *mi;
+ uint64_t cost;
+ int err;
mi = sample__resolve_mem(sample, al);
if (!mi)
@@ -163,7 +169,33 @@ static int perf_c2c__process_load_store(struct perf_c2c *c2c,
return 0;
}
- return 0;
+ cost = sample->weight;
+ if (!cost)
+ cost = 1;
+
+ /*
+ * must pass period=weight in order to get the correct
+ * sorting from hists__collapse_resort() which is solely
+ * based on periods. We want sorting be done on nr_events * weight
+ * and this is indirectly achieved by passing period=weight here
+ * and the he_stat__add_period() function.
+ */
+ he = __hists__add_entry(&c2c->hists, al, parent, NULL, mi,
+ cost, cost, 0);
+ if (!he) {
+ err = -ENOMEM;
+ goto out_mem;
+ }
+
+ c2c->hists.stats.total_period += cost;
+ hists__inc_nr_events(&c2c->hists, PERF_RECORD_SAMPLE);
+ return err;
+
+out_mem:
+ /* implicitly freed by __hists__add_entry */
+ free(mi);
+out:
+ return err;
}
/* setup the basic events for most coverage, options added later */
@@ -266,10 +298,28 @@ out:
return err;
}
+static int perf_c2c__init(struct perf_c2c *c2c)
+{
+ sort__mode = SORT_MODE__PHYSID;
+ sort__wants_unique = 1;
+ sort_order = "daddr,iaddr,pid,tid";
+
+ if (setup_sorting() < 0) {
+ pr_err("can not setup sorting\n");
+ return -1;
+ }
+
+ hists__init(&c2c->hists);
+
+ return 0;
+}
static int perf_c2c__report(struct perf_c2c *c2c)
{
setup_pager();
+ if (perf_c2c__init(c2c))
+ return -1;
+
if (c2c->raw_records)
perf_c2c__fprintf_header(stdout);
--
1.7.11.7
next prev parent reply other threads:[~2014-03-24 19:37 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 19:36 [PATCH 00/15 V3] perf, c2c: Add new tool to analyze cacheline contention on NUMA systems Don Zickus
2014-03-24 19:36 ` [PATCH 01/15 V3] perf: Fix stddev calculation Don Zickus
2014-03-24 19:36 ` [PATCH 02/15 V3] perf, callchain: Add generic callchain print handler for stdio Don Zickus
2014-03-24 19:36 ` [PATCH 03/15 V3] perf c2c: Shared data analyser Don Zickus
2014-04-08 6:59 ` Namhyung Kim
2014-04-08 14:22 ` Don Zickus
2014-04-09 0:58 ` Namhyung Kim
2014-04-09 1:29 ` Andi Kleen
2014-04-08 14:23 ` Don Zickus
2014-03-24 19:36 ` [PATCH 04/15 V3] perf c2c: Dump raw records, decode data_src bits Don Zickus
2014-04-08 7:09 ` Namhyung Kim
2014-03-24 19:36 ` [PATCH 05/15 V3] perf, c2c: Rework setup code to prepare for features Don Zickus
2014-03-29 17:10 ` Jiri Olsa
2014-04-01 2:52 ` Don Zickus
2014-04-08 7:41 ` Namhyung Kim
2014-04-08 14:11 ` Don Zickus
2014-04-09 1:12 ` Namhyung Kim
2014-04-09 1:36 ` Don Zickus
2014-04-11 14:57 ` Jiri Olsa
2014-04-08 7:18 ` Namhyung Kim
2014-03-24 19:36 ` [PATCH 06/15 V3] perf, c2c: Add in new options to configure latency and stores Don Zickus
2014-03-29 17:11 ` Jiri Olsa
2014-04-01 2:55 ` Don Zickus
2014-04-06 13:14 ` Jiri Olsa
2014-04-07 18:16 ` Don Zickus
2014-04-09 0:17 ` Namhyung Kim
2014-04-08 7:37 ` Namhyung Kim
2014-04-08 7:31 ` Namhyung Kim
2014-03-24 19:36 ` Don Zickus [this message]
2014-04-08 7:56 ` [PATCH 07/15 V3] perf, c2c: Add in sort on physid Namhyung Kim
2014-04-08 14:17 ` Don Zickus
2014-04-09 1:30 ` Namhyung Kim
2014-04-09 1:56 ` Don Zickus
2014-03-24 19:36 ` [PATCH 08/15 V3] perf, c2c: Add stats to track data source bits and cpu to node maps Don Zickus
2014-04-08 8:05 ` Namhyung Kim
2014-03-24 19:37 ` [PATCH 09/15 V3] perf, c2c: Sort based on hottest cache line Don Zickus
2014-04-08 8:23 ` Namhyung Kim
2014-03-24 19:37 ` [PATCH 10/15 V3] perf, c2c: Display cacheline HITM analysis to stdout Don Zickus
2014-04-08 8:26 ` Namhyung Kim
2014-04-08 23:46 ` Namhyung Kim
2014-03-24 19:37 ` [PATCH 11/15 V3] perf, c2c: Add callchain support Don Zickus
2014-03-24 19:37 ` [PATCH 12/15 V3] perf, c2c: Output summary stats Don Zickus
2014-03-24 19:37 ` [PATCH 13/15 V3] perf, c2c: Dump rbtree for debugging Don Zickus
2014-03-24 19:37 ` [PATCH 14/15 V3] perf, c2c: Add symbol count table Don Zickus
2014-03-24 19:37 ` [PATCH 15/15 V3] perf, c2c: Add shared cachline summary table Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395689826-215033-8-git-send-email-dzickus@redhat.com \
--to=dzickus@redhat.com \
--cc=acme@ghostprotocols.net \
--cc=andi.kleen@intel.com \
--cc=eranian@google.com \
--cc=fowles@inreach.com \
--cc=jmario@redhat.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®