* [PATCH] [SCSI] hpsa: use trans_support after value assigned
@ 2014-03-26 6:24 SeongJae Park
0 siblings, 0 replies; only message in thread
From: SeongJae Park @ 2014-03-26 6:24 UTC (permalink / raw)
To: scameron, JBottomley
Cc: iss_storagedev, linux-scsi, linux-kernel, SeongJae Park
Because trans_support be used when check i/o accelerator mode support
before its value assigned, it caused following build warning:
drivers/scsi/hpsa.c: In function ‘hpsa_init_one’:
drivers/scsi/hpsa.c:7468:20: warning: ‘trans_support’
may be used uninitialized in this function [-Wmaybe-uninitialized]
if (trans_support & CFGTBL_Trans_io_accel1) {
^
drivers/scsi/hpsa.c:7459:6: note: ‘trans_support’ was
declared here
u32 trans_support;
^
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
drivers/scsi/hpsa.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 8cf4a0c..a4ae873 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -7455,7 +7455,7 @@ clean_up:
static void hpsa_put_ctlr_into_performant_mode(struct ctlr_info *h)
{
- u32 trans_support;
+ u32 trans_support = readl(&(h->cfgtable->TransportSupport));
unsigned long transMethod = CFGTBL_Trans_Performant |
CFGTBL_Trans_use_short_tags;
int i;
@@ -7479,7 +7479,6 @@ static void hpsa_put_ctlr_into_performant_mode(struct ctlr_info *h)
}
/* TODO, check that this next line h->nreply_queues is correct */
- trans_support = readl(&(h->cfgtable->TransportSupport));
if (!(trans_support & PERFORMANT_MODE))
return;
--
1.8.3.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-03-26 6:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-26 6:24 [PATCH] [SCSI] hpsa: use trans_support after value assigned SeongJae Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®