From: Ian Campbell <Ian.Campbell@citrix.com>
To: Zoltan Kiss <zoltan.kiss@citrix.com>
Cc: Paul Durrant <Paul.Durrant@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Jonathan Davies" <Jonathan.Davies@citrix.com>
Subject: Re: [PATCH net-next v2 2/2] xen-netback: Grant copy the header instead of map and memcpy
Date: Wed, 2 Apr 2014 08:29:38 +0100 [thread overview]
Message-ID: <1396423778.26869.61.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <533B0BA7.6040607@citrix.com>
On Tue, 2014-04-01 at 19:55 +0100, Zoltan Kiss wrote:
> >> @@ -1389,7 +1393,7 @@ static int xenvif_tx_submit(struct xenvif
> *vif)
> >> txp = &vif->pending_tx_info[pending_idx].req;
> >>
> >> /* Check the remap error code. */
> >> - if (unlikely(xenvif_tx_check_gop(vif, skb, &gop_map)))
> {
> >> + if (unlikely(xenvif_tx_check_gop(vif, skb, &gop_map,
> >> &gop_copy))) {
> >> netdev_dbg(vif->dev, "netback grant
> failed.\n");
> >
> > It could have been the copy that failed. You should probably change
> the error message.
> I've changed it to "netback grant op failed.\n"
Perhaps xenvif_tx_check_gop is in a position to log something more
specific about the failure? (maybe it already does, I didn't look).
Ian.
next prev parent reply other threads:[~2014-04-02 7:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 15:08 [PATCH net-next v2 1/2] xen-netback: Rename map ops Zoltan Kiss
2014-03-31 15:08 ` [PATCH net-next v2 2/2] xen-netback: Grant copy the header instead of map and memcpy Zoltan Kiss
2014-04-01 9:40 ` Paul Durrant
2014-04-01 18:55 ` Zoltan Kiss
2014-04-02 7:29 ` Ian Campbell [this message]
2014-04-01 11:40 ` Ian Campbell
2014-04-01 19:09 ` Zoltan Kiss
2014-04-02 7:32 ` Ian Campbell
2014-04-02 13:11 ` [Xen-devel] " David Vrabel
2014-04-02 13:15 ` Ian Campbell
2014-04-02 14:41 ` Zoltan Kiss
2014-04-01 11:18 ` [PATCH net-next v2 1/2] xen-netback: Rename map ops Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396423778.26869.61.camel@dagon.hellion.org.uk \
--to=ian.campbell@citrix.com \
--cc=Jonathan.Davies@citrix.com \
--cc=Paul.Durrant@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
--cc=zoltan.kiss@citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome