From: Ian Campbell <Ian.Campbell@citrix.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: Zoltan Kiss <zoltan.kiss@citrix.com>,
<jonathan.davies@citrix.com>, <wei.liu2@citrix.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<paul.durrant@citrix.com>, <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH net-next v2 2/2] xen-netback: Grant copy the header instead of map and memcpy
Date: Wed, 2 Apr 2014 14:15:12 +0100 [thread overview]
Message-ID: <1396444512.8667.340.camel@kazak.uk.xensource.com> (raw)
In-Reply-To: <533C0C9F.8030205@citrix.com>
On Wed, 2014-04-02 at 14:11 +0100, David Vrabel wrote:
> I'd be in favour of a patch that:
>
> - renamed gnttab_map_refs() to gnttab_batch_map_pages()
> - refactored it to call gnttab_batch_map().
> - added documentation
>
> But I don't see why this would be a prerequisite for this series.
No, I think I misunderstoopd the API (because it is confusingly
named...)
>
> David
next prev parent reply other threads:[~2014-04-02 13:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 15:08 [PATCH net-next v2 1/2] xen-netback: Rename map ops Zoltan Kiss
2014-03-31 15:08 ` [PATCH net-next v2 2/2] xen-netback: Grant copy the header instead of map and memcpy Zoltan Kiss
2014-04-01 9:40 ` Paul Durrant
2014-04-01 18:55 ` Zoltan Kiss
2014-04-02 7:29 ` Ian Campbell
2014-04-01 11:40 ` Ian Campbell
2014-04-01 19:09 ` Zoltan Kiss
2014-04-02 7:32 ` Ian Campbell
2014-04-02 13:11 ` [Xen-devel] " David Vrabel
2014-04-02 13:15 ` Ian Campbell [this message]
2014-04-02 14:41 ` Zoltan Kiss
2014-04-01 11:18 ` [PATCH net-next v2 1/2] xen-netback: Rename map ops Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396444512.8667.340.camel@kazak.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=jonathan.davies@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
--cc=zoltan.kiss@citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®