From: Li Zhong <zhong@linux.vnet.ibm.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: nfont@linux.vnet.ibm.com, gregkh@linuxfoundation.org
Subject: [RFC PATCH] memory driver: make phys_index/end_phys_index reflect the start/end section number
Date: Wed, 02 Apr 2014 16:56:58 +0800 [thread overview]
Message-ID: <1396429018.2913.19.camel@ThinkPad-T5421.cn.ibm.com> (raw)
I noticed the phys_index and end_phys_index under
/sys/devices/system/memory/memoryXXX/ have the same value, e.g.
(for the test machine, one memory block has 8 sections, that is
sections_per_block equals 8)
# cd /sys/devices/system/memory/memory100/
# cat phys_index end_phys_index
00000064
00000064
Seems they should reflect the start/end section number respectively, which
also matches what is said in Documentation/memory-hotplug.txt
This patch tries to modify that so the two files could show the start/end
section number of the memory block.
After this change, output of the above example looks like:
# cat phys_index end_phys_index
00000320
00000327
Signed-off-by: Li Zhong <zhong@linux.vnet.ibm.com>
---
drivers/base/memory.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index bece691..b10f2fa 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -114,7 +114,7 @@ static ssize_t show_mem_start_phys_index(struct device *dev,
struct memory_block *mem = to_memory_block(dev);
unsigned long phys_index;
- phys_index = mem->start_section_nr / sections_per_block;
+ phys_index = mem->start_section_nr;
return sprintf(buf, "%08lx\n", phys_index);
}
@@ -124,7 +124,7 @@ static ssize_t show_mem_end_phys_index(struct device *dev,
struct memory_block *mem = to_memory_block(dev);
unsigned long phys_index;
- phys_index = mem->end_section_nr / sections_per_block;
+ phys_index = mem->end_section_nr;
return sprintf(buf, "%08lx\n", phys_index);
}
next reply other threads:[~2014-04-02 8:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 8:56 Li Zhong [this message]
2014-04-02 16:09 ` Dave Hansen
2014-04-03 1:50 ` Li Zhong
2014-04-03 22:41 ` KOSAKI Motohiro
2014-04-03 1:37 ` Zhang Yanfei
2014-04-03 2:37 ` Li Zhong
2014-04-03 3:06 ` Zhang Yanfei
2014-04-03 6:45 ` Li Zhong
2014-04-04 1:29 ` Yasuaki Ishimatsu
2014-04-08 8:27 ` Li Zhong
2014-04-08 16:13 ` Dave Hansen
2014-04-08 18:23 ` Nathan Fontenot
2014-04-08 19:47 ` Dave Hansen
2014-04-09 9:20 ` Li Zhong
2014-04-09 15:49 ` Dave Hansen
2014-04-09 16:16 ` Nathan Fontenot
2014-04-10 3:14 ` Li Zhong
2014-04-10 3:47 ` Zhang Yanfei
2014-04-09 16:20 ` Nathan Fontenot
2014-04-09 17:39 ` Nathan Fontenot
2014-04-10 1:03 ` Zhang Yanfei
2014-04-10 4:17 ` Li Zhong
2014-04-11 18:54 ` Nathan Fontenot
2014-04-14 8:43 ` [RFC PATCH v2] memory-hotplug: Update documentation to hide information about SECTIONS and remove end_phys_index Li Zhong
2014-04-14 9:13 ` Zhang Yanfei
2014-04-15 2:49 ` Li Zhong
2014-04-16 1:49 ` [RFC PATCH v3] " Li Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396429018.2913.19.camel@ThinkPad-T5421.cn.ibm.com \
--to=zhong@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nfont@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®