* [PATCH 03/15] ipc:sem.c #include <linux/uaccess.h>
@ 2014-04-10 18:45 Paul McQuade
2014-04-10 21:49 ` Davidlohr Bueso
0 siblings, 1 reply; 3+ messages in thread
From: Paul McQuade @ 2014-04-10 18:45 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, davidlohr
WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
---
ipc/sem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ipc/sem.c b/ipc/sem.c
index bee5554..3bbfa6c 100644
--- a/ipc/sem.c
+++ b/ipc/sem.c
@@ -87,7 +87,7 @@
#include <linux/nsproxy.h>
#include <linux/ipc_namespace.h>
-#include <asm/uaccess.h>
+#include <linux/uaccess.h>
#include "util.h"
/* One semaphore structure for each semaphore in the system. */
--
1.8.3.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 03/15] ipc:sem.c #include <linux/uaccess.h>
2014-04-10 18:45 [PATCH 03/15] ipc:sem.c #include <linux/uaccess.h> Paul McQuade
@ 2014-04-10 21:49 ` Davidlohr Bueso
2014-04-10 21:51 ` Davidlohr Bueso
0 siblings, 1 reply; 3+ messages in thread
From: Davidlohr Bueso @ 2014-04-10 21:49 UTC (permalink / raw)
To: Paul McQuade; +Cc: linux-kernel, akpm
On Thu, 2014-04-10 at 19:45 +0100, Paul McQuade wrote:
> WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
Nit: the subject should be less code and more text, something like "do
not include asm uaccess directly" or "replace <asm/uaccess.h> by
<linux/uaccess.h>"
Curious, how are you seeing these warnings?
Also, while at it we should probably get rid of the rest in ipc/:
compat.c:#include <asm/uaccess.h>
compat_mq.c:#include <asm/uaccess.h>
msg.c:#include <asm/uaccess.h>
sem.c:#include <asm/uaccess.h>
shm.c:#include <asm/uaccess.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 03/15] ipc:sem.c #include <linux/uaccess.h>
2014-04-10 21:49 ` Davidlohr Bueso
@ 2014-04-10 21:51 ` Davidlohr Bueso
0 siblings, 0 replies; 3+ messages in thread
From: Davidlohr Bueso @ 2014-04-10 21:51 UTC (permalink / raw)
To: Paul McQuade; +Cc: linux-kernel, akpm
On Thu, 2014-04-10 at 14:49 -0700, Davidlohr Bueso wrote:
> On Thu, 2014-04-10 at 19:45 +0100, Paul McQuade wrote:
> > WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
>
> Nit: the subject should be less code and more text, something like "do
> not include asm uaccess directly" or "replace <asm/uaccess.h> by
> <linux/uaccess.h>"
>
> Curious, how are you seeing these warnings?
>
> Also, while at it we should probably get rid of the rest in ipc/:
>
> compat.c:#include <asm/uaccess.h>
> compat_mq.c:#include <asm/uaccess.h>
> msg.c:#include <asm/uaccess.h>
> sem.c:#include <asm/uaccess.h>
> shm.c:#include <asm/uaccess.h>
*sigh* you did but didn't maintain the CCs. It would make a lot more
sense to keep it in the same patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-10 21:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-10 18:45 [PATCH 03/15] ipc:sem.c #include <linux/uaccess.h> Paul McQuade
2014-04-10 21:49 ` Davidlohr Bueso
2014-04-10 21:51 ` Davidlohr Bueso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®