From: Rusty Russell <rusty@rustcorp.com.au>
To: linux-kernel@vger.kernel.org
Cc: Rusty Russell <rusty@rustcorp.com.au>, Simon Wood <simon@mungewell.org>
Subject: [PATCH 3/9] drivers/hid/hid-lg4ff.c: avoid world-writable sysfs files.
Date: Tue, 22 Apr 2014 13:03:26 +0930 [thread overview]
Message-ID: <1398137612-9714-4-git-send-email-rusty@rustcorp.com.au> (raw)
In-Reply-To: <1398137612-9714-1-git-send-email-rusty@rustcorp.com.au>
In line with practice for module parameters, we're adding a build-time
check that sysfs files aren't world-writable.
Cc: Simon Wood <simon@mungewell.org>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
drivers/hid/hid-lg4ff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c
index 24883b4d1a49..cc2bd2022198 100644
--- a/drivers/hid/hid-lg4ff.c
+++ b/drivers/hid/hid-lg4ff.c
@@ -52,7 +52,7 @@ static void hid_lg4ff_set_range_g25(struct hid_device *hid, u16 range);
static ssize_t lg4ff_range_show(struct device *dev, struct device_attribute *attr, char *buf);
static ssize_t lg4ff_range_store(struct device *dev, struct device_attribute *attr, const char *buf, size_t count);
-static DEVICE_ATTR(range, S_IRWXU | S_IRWXG | S_IRWXO, lg4ff_range_show, lg4ff_range_store);
+static DEVICE_ATTR(range, S_IRWXU | S_IRWXG | S_IROTH, lg4ff_range_show, lg4ff_range_store);
struct lg4ff_device_entry {
__u32 product_id;
--
1.8.3.2
next prev parent reply other threads:[~2014-04-22 3:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 3:33 [PATCH 0/9] Avoid " Rusty Russell
2014-04-22 3:33 ` [PATCH 1/9] drivers/mtd/devices/docg3.c: avoid " Rusty Russell
2014-04-22 3:33 ` [PATCH 2/9] drivers/video/fbdev/sm501fb.c: " Rusty Russell
2014-04-22 3:33 ` Rusty Russell [this message]
2014-04-22 16:30 ` [PATCH 3/9] drivers/hid/hid-lg4ff.c: " simon
2014-04-23 5:34 ` Rusty Russell
2014-04-23 15:06 ` simon
2014-04-24 3:25 ` Rusty Russell
[not found] ` <gz6xrj.n4iwpm.2st9zt-qmf@smtp.devoid-pointer.net>
2014-04-24 7:14 ` Rusty Russell
2014-04-22 3:33 ` [PATCH 4/9] drivers/scsi/pm8001/pm8001_ctl.c: " Rusty Russell
2014-04-22 3:33 ` [PATCH 5/9] drivers/regulator/virtual: " Rusty Russell
2014-04-22 3:33 ` [PATCH 6/9] drivers/staging/speakup/: " Rusty Russell
2014-04-22 16:37 ` Greg Kroah-Hartman
2014-04-24 4:27 ` Rusty Russell
2014-04-24 19:29 ` Greg Kroah-Hartman
2014-04-22 3:33 ` [PATCH 7/9] drivers/hid/hid-picolcd_fb: " Rusty Russell
2014-05-02 19:43 ` Bruno Prémont
2014-05-05 1:57 ` Rusty Russell
2014-05-05 9:02 ` Jiri Kosina
2014-04-22 3:33 ` [PATCH 8/9] samples/kobject/: " Rusty Russell
2014-04-22 16:38 ` Greg Kroah-Hartman
2014-04-22 3:33 ` [PATCH 9/9] sysfs: disallow world-writable files Rusty Russell
2015-04-29 12:24 ` Gobinda Charan Maji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398137612-9714-4-git-send-email-rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=simon@mungewell.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome